third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp - Issue 2273483003: [WONT COMMIT] WebSocket: Signal when worker thread lifecycle context is destroyed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp

Issue 2273483003: [WONT COMMIT] WebSocket: Signal when worker thread lifecycle context is destroyed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h ('K') | « third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp

diff --git a/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp b/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp

index 4bcf08becbb71b9600024e3f42871149fbc8fff9..fd53aef9a5988acd752118b16387f29928d74c19 100644

--- a/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp

+++ b/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp

@@ -365,10 +365,7 @@ void Peer::didError()

void Peer::contextDestroyed()

{

DCHECK(isMainThread());

- if (m_mainWebSocketChannel) {

- m_mainWebSocketChannel->disconnect();

- m_mainWebSocketChannel = nullptr;

- }

+ disconnect();

m_bridge = nullptr;

}