[WONT COMMIT] WebSocket: Signal when worker thread lifecycle context is destroyed

WebSocket: Signal when worker thread lifecycle context is destroyed

This should be necessary to unblock a worker thread and make sure to run
closing sequence on it before termination.

BUG=640088

[nhiroki, 2016-08-23 04:45:16]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 04:45:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2016-08-23 04:47:35]

nhiroki@chromium.org changed reviewers:
+ yhirano@chromium.org

[nhiroki, 2016-08-23 04:47:36]

Ptal, thanks!

(Is there an existing crbug issue that is suitable for this CL?)

[yhirano, 2016-08-23 04:51:48]

lgtm

https://codereview.chromium.org/2273483003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h
(right):

https://codereview.chromium.org/2273483003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h:126:
Member<DocumentWebSocketChannel> m_mainWebSocketChannel;
Just out of curiosity, is this change needed?

[haraken, 2016-08-23 04:52:14]

LGTM

[nhiroki, 2016-08-23 04:56:46]

Thank you!

https://codereview.chromium.org/2273483003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h
(right):

https://codereview.chromium.org/2273483003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h:126:
Member<DocumentWebSocketChannel> m_mainWebSocketChannel;
On 2016/08/23 04:51:48, yhirano wrote:
> Just out of curiosity, is this change needed?

Not needed. This is just for improving readability on codesearch. If you prefer
to have a separate CL for this, I'll make it :)

[yhirano, 2016-08-23 05:01:08]

On 2016/08/23 04:56:46, nhiroki wrote:
> Thank you!
> 
>
https://codereview.chromium.org/2273483003/diff/1/third_party/WebKit/Source/m...
> File third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h
> (right):
> 
>
https://codereview.chromium.org/2273483003/diff/1/third_party/WebKit/Source/m...
> third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h:126:
> Member<DocumentWebSocketChannel> m_mainWebSocketChannel;
> On 2016/08/23 04:51:48, yhirano wrote:
> > Just out of curiosity, is this change needed?
> 
> Not needed. This is just for improving readability on codesearch. If you
prefer
> to have a separate CL for this, I'll make it :)

Thank you, there's no problem to land this cl.

[nhiroki, 2016-08-23 05:20:55]

Description was changed from

==========
WebSocket: Signal when worker thread lifecycle context is destroyed

This should be necessary to unblock a worker thread and make sure to run
closing sequence on it before termination.

BUG=
==========

to

==========
WebSocket: Signal when worker thread lifecycle context is destroyed

This should be necessary to unblock a worker thread and make sure to run
closing sequence on it before termination.

BUG=640088
==========

[nhiroki, 2016-08-23 05:21:13]

The CQ bit was unchecked by nhiroki@chromium.org

[nhiroki, 2016-08-23 05:21:13]

The CQ bit was checked by nhiroki@chromium.org

[commit-bot: I haz the power, 2016-08-23 05:21:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 06:09:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 06:09:52]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nhiroki, 2016-08-23 06:19:01]

This change fails following tests:

http/tests/websocket/workers/worker-open-reload-repeated.html
http/tests/websocket/workers/worker-stall-reload-repeated.html
http/tests/websocket/workers/worker-reload.html

I'll investigate...

[nhiroki, 2016-08-24 05:28:13]

On 2016/08/23 06:19:01, nhiroki wrote:
> This change fails following tests:
> 
> http/tests/websocket/workers/worker-open-reload-repeated.html
> http/tests/websocket/workers/worker-stall-reload-repeated.html
> http/tests/websocket/workers/worker-reload.html
> 
> I'll investigate...

Although I don't know the exact reason of test failures yet, apparently multiple
signalWorkerThread() calls could cause it. I'm now refactoring usage of
WebSocketChannelSyncHelper to reduce callsites of the function. For example,
https://codereview.chromium.org/2270693002/

[nhiroki, 2016-08-24 08:38:56]

Let me close this CL in favor of https://codereview.chromium.org/2271133002/