Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 2273483002: [wasm] Clone indirect function table when instantiating. (Closed)

Created:
4 years, 4 months ago by Mircea Trofin
Modified:
4 years, 4 months ago
Reviewers:
bradnelson
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Clone indirect function table when instantiating. Clone the indirect function table(s) when instantiating. This is in preparation to avoiding having a compiled code template. BUG= Committed: https://crrev.com/f11270fd9de94d140f4a55564a7146862529e758 Cr-Commit-Position: refs/heads/master@{#38807}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -30 lines) Patch
M src/wasm/wasm-module.cc View 3 chunks +30 lines, -30 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Mircea Trofin
4 years, 4 months ago (2016-08-23 04:05:12 UTC) #5
bradnelson
lgtm
4 years, 4 months ago (2016-08-23 04:09:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2273483002/1
4 years, 4 months ago (2016-08-23 04:22:27 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-23 04:24:26 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 04:24:45 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f11270fd9de94d140f4a55564a7146862529e758
Cr-Commit-Position: refs/heads/master@{#38807}

Powered by Google App Engine
This is Rietveld 408576698