Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 2273423002: In URI resolution tests, don't access the local filesystem. (Closed)

Created:
4 years, 3 months ago by Paul Berry
Modified:
4 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

In URI resolution tests, don't access the local filesystem. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/30223ae8072c1369cd3d665f1aca48e093803ebd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -20 lines) Patch
M pkg/analyzer/test/generated/all_the_rest_test.dart View 5 chunks +29 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 3 months ago (2016-08-25 21:03:55 UTC) #2
Brian Wilkerson
lgtm
4 years, 3 months ago (2016-08-25 21:06:31 UTC) #3
Paul Berry
4 years, 3 months ago (2016-08-25 21:08:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
30223ae8072c1369cd3d665f1aca48e093803ebd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698