Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Unified Diff: components/cronet/ios/BUILD.gn

Issue 2273403003: Moving gRPC support interfaces out of cronet and into a new component. (Closed)
Patch Set: Add DEPS Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/ios/BUILD.gn
diff --git a/components/cronet/ios/BUILD.gn b/components/cronet/ios/BUILD.gn
index 027b66da0ae8ce294923041194f8c9415798fe85..7b7afa1857ad5a802bfe4db7f10df892ffa6ef15 100644
--- a/components/cronet/ios/BUILD.gn
+++ b/components/cronet/ios/BUILD.gn
@@ -8,6 +8,7 @@ import("//build/config/mac/symbols.gni")
import("//build/mac/tweak_info_plist.gni")
import("//build/util/process_version.gni")
import("//build/util/version.gni")
+import("//components/grpc_support/include/headers.gni")
import("//testing/test.gni")
import("//url/features.gni")
@@ -33,6 +34,7 @@ source_set("cronet_sources") {
deps = [
":cronet_version_header",
"//base:base",
+ "//components/grpc_support",
"//components/metrics:metrics",
"//components/metrics/proto:proto",
"//components/prefs:prefs",
@@ -47,10 +49,6 @@ source_set("cronet_sources") {
"../stale_host_resolver.h",
"../url_request_context_config.cc",
"../url_request_context_config.h",
- "cronet_bidirectional_stream.cc",
- "cronet_bidirectional_stream.h",
- "cronet_c_for_grpc.cc",
- "cronet_c_for_grpc.h",
"cronet_environment.cc",
"cronet_environment.h",
]
@@ -78,11 +76,15 @@ ios_framework_bundle("cronet_framework") {
libs = [ "UIKit.Framework" ]
- public_headers = [
- "Cronet.h",
- "cronet_c_for_grpc.h",
+ include_dirs = [ "//components/grpc_support/include" ]
+
+ public_deps = [
+ "//components/grpc_support",
]
+ public_headers = [ "Cronet.h" ]
+ public_headers += grpc_public_headers
+
sources = [
"Cronet.h",
"Cronet.mm",
@@ -120,6 +122,7 @@ test("cronet_test") {
":cronet_version_header",
"//base",
"//base:i18n",
+ "//components/grpc_support",
"//net",
"//net:simple_quic_tools",
"//net:test_support",

Powered by Google App Engine
This is Rietveld 408576698