components/grpc_support/DEPS - Issue 2273403003: Moving gRPC support interfaces out of cronet and into a new component.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/grpc_support/DEPS

Issue 2273403003: Moving gRPC support interfaces out of cronet and into a new component. (Closed)

Patch Set: Revert rules.gni for testing Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+net",	2 "+net",
	blundell 2016/10/06 08:31:08 Would it be OK to add DEPS here since this is just Would it be OK to add DEPS here since this is just on the implementation, or should this not grow DEPS beyond //net? If the latter, it would be good to note that explicitly in a comment here. Garrett Casto 2016/10/06 21:58:27 This is just the implementation, so dependencies c Show quoted text On 2016/10/06 08:31:08, blundell wrote: > Would it be OK to add DEPS here since this is just on the implementation, or > should this not grow DEPS beyond //net? If the latter, it would be good to note > that explicitly in a comment here. This is just the implementation, so dependencies can be added here.
3 ]	3 ]

OLD	NEW