Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 22734004: Extend sharding_supervisor.py to accept the --verbose and --retries options. (Closed)

Created:
7 years, 4 months ago by Alexander Potapenko
Modified:
7 years, 3 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Extend sharding_supervisor.py to accept the --verbose and --retries options. These are passed to run_test_cases.py R=maruel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220544

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M tools/sharding_supervisor/sharding_supervisor.py View 1 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Alexander Potapenko
PTAL when you have time.
7 years, 4 months ago (2013-08-09 12:32:06 UTC) #1
M-A Ruel
https://codereview.chromium.org/22734004/diff/1/tools/sharding_supervisor/sharding_supervisor.py File tools/sharding_supervisor/sharding_supervisor.py (right): https://codereview.chromium.org/22734004/diff/1/tools/sharding_supervisor/sharding_supervisor.py#newcode64 tools/sharding_supervisor/sharding_supervisor.py:64: '--verbose', action='store_true', help='Kept as --verbose') default=0, action='count' https://codereview.chromium.org/22734004/diff/1/tools/sharding_supervisor/sharding_supervisor.py#newcode85 tools/sharding_supervisor/sharding_supervisor.py:85: ...
7 years, 4 months ago (2013-08-12 14:29:59 UTC) #2
Alexander Potapenko
https://codereview.chromium.org/22734004/diff/1/tools/sharding_supervisor/sharding_supervisor.py File tools/sharding_supervisor/sharding_supervisor.py (right): https://codereview.chromium.org/22734004/diff/1/tools/sharding_supervisor/sharding_supervisor.py#newcode64 tools/sharding_supervisor/sharding_supervisor.py:64: '--verbose', action='store_true', help='Kept as --verbose') On 2013/08/12 14:29:59, M-A ...
7 years, 4 months ago (2013-08-12 14:33:53 UTC) #3
Alexander Potapenko
Ping. Anything else?
7 years, 4 months ago (2013-08-15 09:18:49 UTC) #4
M-A Ruel
lgtm, sorry it fell through.
7 years, 4 months ago (2013-08-15 14:30:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/22734004/6001
7 years, 3 months ago (2013-08-29 14:46:49 UTC) #6
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=73990
7 years, 3 months ago (2013-08-29 23:44:31 UTC) #7
Alexander Potapenko
7 years, 3 months ago (2013-08-30 09:34:43 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r220544 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698