Remove mask parameter from TypeMask.locateSingleElement

Remove mask parameter from TypeMask.locateSingleElement

BUG=
R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/200c53654a4b57addbbdac53f0911874a294720c

[sra1, 2016-08-26 00:45:26]

sra@google.com changed reviewers:
+ johnniwinther@google.com

[sra1, 2016-08-26 00:45:27]

This looks to me like an oversight from removing TypedSelector.

What do you think?

I found this while spelunking https://github.com/dart-lang/sdk/issues/27160

https://codereview.chromium.org/2273393003/diff/1/pkg/compiler/lib/src/types/...
File pkg/compiler/lib/src/types/union_type_mask.dart (left):

https://codereview.chromium.org/2273393003/diff/1/pkg/compiler/lib/src/types/...
pkg/compiler/lib/src/types/union_type_mask.dart:338: Element current =
mask.locateSingleElement(selector, mask, compiler);
Was the argument supposed to be the parameter or the loop variable?

[Johnni Winther, 2016-08-26 08:59:02]

I've always wondered why TypeMask.locateSingleElement took a TypeMask ;)

Can you make unittest that validates the effect?

Otherwise LGTM

[sra1, 2016-08-26 16:33:26]

Description was changed from

==========
Remove mask parameter from TypeMask.locateSingleElement

BUG=
==========

to

==========
Remove mask parameter from TypeMask.locateSingleElement

BUG=
R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/200c53654a4b57addbbdac53f0911874a294720c
==========

[sra1, 2016-08-26 16:33:27]

Committed patchset #1 (id:1) manually as
200c53654a4b57addbbdac53f0911874a294720c (presubmit successful).

[sra1, 2016-08-26 16:35:06]

On 2016/08/26 08:59:02, Johnni Winther wrote:
> I've always wondered why TypeMask.locateSingleElement took a TypeMask ;)
> 
> Can you make unittest that validates the effect?

The effect should be nothing since 'mask' is redundant with 'this'.
I compiled lots of tests and a few apps and there was no difference.

> 
> Otherwise LGTM