Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2273383002: Cleaning up remoting GN build files. Condense the sources. (Closed)

Created:
4 years, 3 months ago by nicholss
Modified:
4 years, 3 months ago
Reviewers:
joedow
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleaning up remoting GN build files. Condense the sources. Start step in a multi-commit to reformat the Remoting build files to be more in-line with how a GN build system should look. This CL removes the gyp sources file to allow moving of the build files and sources to further down the source tree. Without this change, the future changes look too scary to reviews. Committed: https://crrev.com/336d51f5105c5079da6bd099b6e3843fc759a46b Cr-Commit-Position: refs/heads/master@{#414514}

Patch Set 1 : Cleaning up remoting GN build files. Condense the sources. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+722 lines, -79 lines) Patch
M remoting/base/BUILD.gn View 1 chunk +37 lines, -5 lines 0 comments Download
M remoting/client/BUILD.gn View 2 chunks +63 lines, -13 lines 0 comments Download
M remoting/client/plugin/BUILD.gn View 1 chunk +34 lines, -5 lines 0 comments Download
M remoting/codec/BUILD.gn View 1 chunk +30 lines, -5 lines 0 comments Download
M remoting/host/BUILD.gn View 3 chunks +302 lines, -6 lines 0 comments Download
M remoting/host/it2me/BUILD.gn View 2 chunks +11 lines, -5 lines 0 comments Download
M remoting/host/native_messaging/BUILD.gn View 1 chunk +12 lines, -7 lines 0 comments Download
M remoting/host/setup/BUILD.gn View 1 chunk +25 lines, -6 lines 0 comments Download
M remoting/protocol/BUILD.gn View 2 chunks +186 lines, -8 lines 0 comments Download
M remoting/remoting_options.gni View 1 chunk +3 lines, -0 lines 1 comment Download
D remoting/remoting_srcs.gni View 1 chunk +0 lines, -14 lines 0 comments Download
M remoting/signaling/BUILD.gn View 1 chunk +19 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (11 generated)
nicholss
PTAL!
4 years, 3 months ago (2016-08-25 17:20:11 UTC) #7
joedow
lgtm https://codereview.chromium.org/2273383002/diff/20001/remoting/remoting_options.gni File remoting/remoting_options.gni (right): https://codereview.chromium.org/2273383002/diff/20001/remoting/remoting_options.gni#newcode45 remoting/remoting_options.gni:45: rdp_desktop_session_guid = "6a7699f0-ee43-43e7-aa30-a6738f9bd470" These are windows only so ...
4 years, 3 months ago (2016-08-25 17:33:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2273383002/20001
4 years, 3 months ago (2016-08-25 19:46:13 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-08-25 19:52:31 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 19:54:06 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/336d51f5105c5079da6bd099b6e3843fc759a46b
Cr-Commit-Position: refs/heads/master@{#414514}

Powered by Google App Engine
This is Rietveld 408576698