Ensure focus() gets called when navigating to text fields

Ensure focus() gets called when navigating to text fields

This was a recent regression. Logic was added to make a top level editable a container (so that navigation would descend into it). However, we were previously using the container predicate to decide whether or not to set focus; this prevents focus() on roots which sometimes triggered other side effects such as focusing a descendant.

Make the focus precondition check the structuralContainer predicate instead.

BUG=640587
TEST=chromevox_tests

Committed: https://crrev.com/2063c5ec1c11f5b9823d8df8cbe647c5e9168c63
Cr-Commit-Position: refs/heads/master@{#414871}

[David Tseng, 2016-08-25 16:41:37]

Description was changed from

==========
Restore focus behavior for text fields when navigating.
==========

to

==========
Restore focus behavior for text fields when navigating.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-08-25 16:46:01]

Description was changed from

==========
Restore focus behavior for text fields when navigating.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Ensure focus() gets called when navigating to text fields


This was a recent regression. Logic was added to make an top level editable a
container (so that navigation would descend into it). However, we were
previously using the container predicate to decide whether or not to set focus;
this prevents focus() on roots which sometimes triggered other side effects such
as focusing a descendant.

Make the focus precondition check the structuralContainer predicate instead.

BUG=640587
TEST=chromevox_tests
==========

[David Tseng, 2016-08-25 16:46:02]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[David Tseng, 2016-08-25 16:46:33]

Description was changed from

==========
Ensure focus() gets called when navigating to text fields


This was a recent regression. Logic was added to make an top level editable a
container (so that navigation would descend into it). However, we were
previously using the container predicate to decide whether or not to set focus;
this prevents focus() on roots which sometimes triggered other side effects such
as focusing a descendant.

Make the focus precondition check the structuralContainer predicate instead.

BUG=640587
TEST=chromevox_tests
==========

to

==========
Ensure focus() gets called when navigating to text fields

This was a recent regression. Logic was added to make a top level editable a
container (so that navigation would descend into it). However, we were
previously using the container predicate to decide whether or not to set focus;
this prevents focus() on roots which sometimes triggered other side effects such
as focusing a descendant.

Make the focus precondition check the structuralContainer predicate instead.

BUG=640587
TEST=chromevox_tests
==========

[David Tseng, 2016-08-25 17:16:10]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 17:16:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 20:37:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 20:37:45]

Dry run: This issue passed the CQ dry run.

[David Tseng, 2016-08-26 21:27:43]

Friendly pri 1 bug ping.

[dmazzoni, 2016-08-26 22:30:21]

lgtm

[David Tseng, 2016-08-26 22:33:31]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2016-08-26 22:34:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-27 00:10:44]

Description was changed from

==========
Ensure focus() gets called when navigating to text fields

This was a recent regression. Logic was added to make a top level editable a
container (so that navigation would descend into it). However, we were
previously using the container predicate to decide whether or not to set focus;
this prevents focus() on roots which sometimes triggered other side effects such
as focusing a descendant.

Make the focus precondition check the structuralContainer predicate instead.

BUG=640587
TEST=chromevox_tests
==========

to

==========
Ensure focus() gets called when navigating to text fields

This was a recent regression. Logic was added to make a top level editable a
container (so that navigation would descend into it). However, we were
previously using the container predicate to decide whether or not to set focus;
this prevents focus() on roots which sometimes triggered other side effects such
as focusing a descendant.

Make the focus precondition check the structuralContainer predicate instead.

BUG=640587
TEST=chromevox_tests
==========

[commit-bot: I haz the power, 2016-08-27 00:10:45]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-27 00:14:34]

Description was changed from

==========
Ensure focus() gets called when navigating to text fields

This was a recent regression. Logic was added to make a top level editable a
container (so that navigation would descend into it). However, we were
previously using the container predicate to decide whether or not to set focus;
this prevents focus() on roots which sometimes triggered other side effects such
as focusing a descendant.

Make the focus precondition check the structuralContainer predicate instead.

BUG=640587
TEST=chromevox_tests
==========

to

==========
Ensure focus() gets called when navigating to text fields

This was a recent regression. Logic was added to make a top level editable a
container (so that navigation would descend into it). However, we were
previously using the container predicate to decide whether or not to set focus;
this prevents focus() on roots which sometimes triggered other side effects such
as focusing a descendant.

Make the focus precondition check the structuralContainer predicate instead.

BUG=640587
TEST=chromevox_tests

Committed: https://crrev.com/2063c5ec1c11f5b9823d8df8cbe647c5e9168c63
Cr-Commit-Position: refs/heads/master@{#414871}
==========

[commit-bot: I haz the power, 2016-08-27 00:14:35]

Patchset 1 (id:??) landed as
https://crrev.com/2063c5ec1c11f5b9823d8df8cbe647c5e9168c63
Cr-Commit-Position: refs/heads/master@{#414871}