BUILD.gn - Issue 2273343002: SkPDF: Stop `#include PREPROCESSOR_DEFINE` pattern

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: BUILD.gn

Issue 2273343002: SkPDF: Stop `#include PREPROCESSOR_DEFINE` pattern (Closed)

Patch Set: fix gyp/pdf.gyp syntax error Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn

index 8bc4505d655534fdf35ead527ba699e5676a0383..aeed64c285d5b8900a90f5638a5a407fce009aa4 100644

--- a/BUILD.gn

+++ b/BUILD.gn

@@ -285,10 +285,7 @@ optional("pdf") {

if (skia_use_sfntly) {

deps += [ "//third_party/sfntly" ]

- public_defines += [

- # TODO(halcanary): make this the default; this is the value Android uses.

- "SK_SFNTLY_SUBSETTER=\"sample/chromium/font_subsetter.h\"",

- ]

+ public_defines += [ "SK_PDF_USE_SFNTLY" ]

}

« no previous file with comments | « no previous file | gyp/common_conditions.gypi » ('j') | no next file with comments »