Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 2273343002: SkPDF: Stop `#include PREPROCESSOR_DEFINE` pattern (Closed)

Created:
4 years, 3 months ago by hal.canary
Modified:
4 years, 3 months ago
Reviewers:
mtklein, djsollen
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: Stop `#include PREPROCESSOR_DEFINE` pattern No more: #include SK_SFNTLY_SUBSETTER #include ZLIB_INCLUDE Also, rename SK_SFNTLY_SUBSETTER to SK_PDF_USE_SFNTLY to follow my pattern of prefixing SkPDF-specific defines with 'SK_PDF_'. The ZLIB_INCLUDE define is no longer is used by anyone. TODO: rename Sfntly to something pronounceable. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2273343002 Committed: https://skia.googlesource.com/skia/+/650e20d705a39eaa861cfbc821e9e1f81cef5316

Patch Set 1 : fix gyp/pdf.gyp syntax error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -35 lines) Patch
M BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M gyp/common_conditions.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/pdf.gyp View 1 chunk +6 lines, -4 lines 0 comments Download
M gyp/sfntly.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M public.bzl View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkDeflate.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M src/pdf/SkPDFFont.cpp View 6 chunks +12 lines, -12 lines 0 comments Download
M tests/PDFDeflateWStreamTest.cpp View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
hal.canary
ptal djsollen@, see changes that effect skia_android_framework
4 years, 3 months ago (2016-08-25 15:05:43 UTC) #11
mtklein
lgtm
4 years, 3 months ago (2016-08-25 15:11:35 UTC) #12
djsollen
lgtm
4 years, 3 months ago (2016-08-25 15:51:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2273343002/20001
4 years, 3 months ago (2016-08-25 16:06:07 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 16:07:05 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://skia.googlesource.com/skia/+/650e20d705a39eaa861cfbc821e9e1f81cef5316

Powered by Google App Engine
This is Rietveld 408576698