Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 2273293004: path ops stream-lining (Closed)

Created:
4 years, 3 months ago by caryclark
Modified:
4 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

path ops stream-lining The addT() function is a workhorse of pathops. Make it simpler, removing branches and parameters. Separate addOpp() into const and modify parts. Add more debugging that asserts if the function fails and the data is not extreme (e.g., fuzzer generated). TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2273293004 Committed: https://skia.googlesource.com/skia/+/29b2563afb1677515739f1d24fb27733626eca92

Patch Set 1 #

Patch Set 2 : remove commented out code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -118 lines) Patch
M src/pathops/SkAddIntersections.cpp View 1 1 chunk +5 lines, -4 lines 0 comments Download
M src/pathops/SkOpCoincidence.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/pathops/SkOpSegment.h View 3 chunks +5 lines, -3 lines 0 comments Download
M src/pathops/SkOpSegment.cpp View 2 chunks +18 lines, -37 lines 0 comments Download
M src/pathops/SkOpSpan.h View 4 chunks +18 lines, -14 lines 0 comments Download
M src/pathops/SkOpSpan.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/pathops/SkPathOpsDebug.h View 1 chunk +11 lines, -4 lines 0 comments Download
M src/pathops/SkPathOpsDebug.cpp View 7 chunks +21 lines, -48 lines 0 comments Download
M src/pathops/SkPathOpsTypes.h View 3 chunks +13 lines, -0 lines 0 comments Download
M tests/PathOpsAngleTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2273293004/20001
4 years, 3 months ago (2016-08-25 17:59:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot/builds/9342)
4 years, 3 months ago (2016-08-25 18:01:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2273293004/20001
4 years, 3 months ago (2016-08-25 18:23:27 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 18:27:20 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/29b2563afb1677515739f1d24fb27733626eca92

Powered by Google App Engine
This is Rietveld 408576698