Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(915)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2273293003: Check for nullptrs in CPDF_Dictionary dtor. (Closed)

Created:
4 years, 3 months ago by Lei Zhang
Modified:
4 years, 3 months ago
Reviewers:
Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Check for nullptrs in CPDF_Dictionary dtor. BUG=597440 Committed: https://pdfium.googlesource.com/pdfium/+/22b176d0ee7f1dcbc7bca6e5eef65c19fa10f726

Patch Set 1 #

Patch Set 2 : nit #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -16 lines) Patch
M core/fpdfapi/fpdf_parser/cpdf_array.cpp View 5 chunks +13 lines, -10 lines 1 comment Download
M core/fpdfapi/fpdf_parser/cpdf_dictionary.cpp View 1 2 chunks +9 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp View 2 chunks +41 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Lei Zhang
https://codereview.chromium.org/2273293003/diff/20001/core/fpdfapi/fpdf_parser/cpdf_array.cpp File core/fpdfapi/fpdf_parser/cpdf_array.cpp (right): https://codereview.chromium.org/2273293003/diff/20001/core/fpdfapi/fpdf_parser/cpdf_array.cpp#newcode25 core/fpdfapi/fpdf_parser/cpdf_array.cpp:25: if (it) Same check here.
4 years, 3 months ago (2016-08-25 17:20:24 UTC) #4
Wei Li
lgtm
4 years, 3 months ago (2016-08-25 17:40:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2273293003/20001
4 years, 3 months ago (2016-08-25 18:14:10 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 18:14:25 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/22b176d0ee7f1dcbc7bca6e5eef65c19fa10...

Powered by Google App Engine
This is Rietveld 408576698