Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4450)

Unified Diff: ash/common/system/chromeos/palette/tools/capture_region_action.cc

Issue 2273273003: Update strings for ash palette and rename options/settings files. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/system/chromeos/palette/tools/capture_region_action.cc
diff --git a/ash/common/system/chromeos/palette/tools/capture_region_action.cc b/ash/common/system/chromeos/palette/tools/capture_region_action.cc
index 51a7c75890dc04ca260e28559ce24336375c9e2f..a8b4e2cabb6692e7b7bddcf430a55303aeb545a5 100644
--- a/ash/common/system/chromeos/palette/tools/capture_region_action.cc
+++ b/ash/common/system/chromeos/palette/tools/capture_region_action.cc
@@ -10,7 +10,6 @@
#include "ash/common/system/toast/toast_data.h"
#include "ash/common/system/toast/toast_manager.h"
#include "ash/common/wm_shell.h"
-#include "base/strings/utf_string_conversions.h"
#include "grit/ash_strings.h"
#include "ui/base/l10n/l10n_util.h"
@@ -21,9 +20,6 @@ namespace {
const char kToastId[] = "palette_capture_region";
const int kToastDurationMs = 2500;
-// TODO(jdufault): Localize toast message. See crbug.com/634558.
-const char kToastMessage[] = "Select a region";
-
} // namespace
CaptureRegionAction::CaptureRegionAction(Delegate* delegate)
@@ -42,8 +38,9 @@ PaletteToolId CaptureRegionAction::GetToolId() const {
void CaptureRegionAction::OnEnable() {
CommonPaletteTool::OnEnable();
- ToastData toast(kToastId, base::ASCIIToUTF16(kToastMessage), kToastDurationMs,
- base::string16());
+ ToastData toast(
+ kToastId, l10n_util::GetStringUTF16(IDS_ASH_PALETTE_CAPTURE_REGION_TOAST),
+ kToastDurationMs, base::string16());
ash::WmShell::Get()->toast_manager()->Show(toast);
WmShell::Get()->palette_delegate()->TakePartialScreenshot();

Powered by Google App Engine
This is Rietveld 408576698