chrome/browser/ui/views/omnibox/omnibox_view_views.h - Issue 2273263002: MacViewsBrowser: Fix omnibox crash due to failed DCHECK.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.h

Issue 2273263002: MacViewsBrowser: Fix omnibox crash due to failed DCHECK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review, make Textfield::OnKeyPressed/Released final. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/omnibox/omnibox_view_views.h

diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.h b/chrome/browser/ui/views/omnibox/omnibox_view_views.h

index 3bda3d6b9a4ecb119281ea983c66f9c98032e9c8..2ffee04330fc6137ba77e5cbaca56430e9b1a4ee 100644

--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.h

+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.h

@@ -162,14 +162,12 @@ class OmniboxViewViews

void EmphasizeURLComponents() override;

// views::Textfield:

- bool OnKeyReleased(const ui::KeyEvent& event) override;

bool IsItemForCommandIdDynamic(int command_id) const override;

base::string16 GetLabelForCommandId(int command_id) const override;

const char* GetClassName() const override;

bool OnMousePressed(const ui::MouseEvent& event) override;

bool OnMouseDragged(const ui::MouseEvent& event) override;

void OnMouseReleased(const ui::MouseEvent& event) override;

- bool OnKeyPressed(const ui::KeyEvent& event) override;

void OnGestureEvent(ui::GestureEvent* event) override;

void AboutToRequestFocusFromTabTraversal(bool reverse) override;

bool SkipDefaultKeyEventProcessing(const ui::KeyEvent& event) override;

« no previous file with comments | « no previous file | chrome/browser/ui/views/omnibox/omnibox_view_views.cc » ('j') | no next file with comments »