ui/app_list/views/search_box_view_unittest.cc - Issue 2273263002: MacViewsBrowser: Fix omnibox crash due to failed DCHECK.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/app_list/views/search_box_view_unittest.cc

Issue 2273263002: MacViewsBrowser: Fix omnibox crash due to failed DCHECK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix compile. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc ('k') | ui/views/controls/textfield/textfield.h » ('j') | ui/views/controls/textfield/textfield_test_api.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/app_list/views/search_box_view_unittest.cc

diff --git a/ui/app_list/views/search_box_view_unittest.cc b/ui/app_list/views/search_box_view_unittest.cc

index e1d777a6a2dbfe72e543ae5cdd03ecdef08844ae..d2a3041df7942c872308093b22bfe8576ae452b2 100644

--- a/ui/app_list/views/search_box_view_unittest.cc

+++ b/ui/app_list/views/search_box_view_unittest.cc

@@ -12,6 +12,7 @@

#include "ui/app_list/test/app_list_test_view_delegate.h"

#include "ui/app_list/views/search_box_view_delegate.h"

#include "ui/views/controls/textfield/textfield.h"

+#include "ui/views/controls/textfield/textfield_test_api.h"

#include "ui/views/test/widget_test.h"

namespace app_list {

@@ -86,7 +87,8 @@ class SearchBoxViewTest : public views::test::WidgetTest,

void KeyPress(ui::KeyboardCode key_code) {

ui::KeyEvent event(ui::ET_KEY_PRESSED, key_code, ui::EF_NONE);

- view_->search_box()->OnKeyPressed(event);

+ views::TextfieldTestApi test_api_(view_->search_box());

+ test_api_.OnKeyPressed(event);

// Emulates the input method.

if (::isalnum(static_cast<int>(key_code))) {

base::char16 character = ::tolower(static_cast<int>(key_code));