MacViewsBrowser: Fix omnibox crash due to failed DCHECK.

chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/omnibox/omnibox_view_views.h"
 
 #include <stddef.h>
 
 #include <memory>
 
 #include "base/macros.h"
 #include "build/build_config.h"
 #include "chrome/browser/command_updater.h"
 #include "chrome/browser/ui/omnibox/chrome_omnibox_edit_controller.h"
 #include "chrome/test/base/testing_profile.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "testing/gtest/include/gtest/gtest.h"
+#include "ui/base/ime/text_edit_commands.h"
 #include "ui/events/event_utils.h"
 #include "ui/events/keycodes/dom/dom_code.h"
+#include "ui/views/controls/textfield/textfield_test_api.h"
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/chromeos/input_method/input_method_configuration.h"
 #include "chrome/browser/chromeos/input_method/mock_input_method_manager.h"
 #endif
 
 namespace {
 
 class TestingOmniboxViewViews : public OmniboxViewViews {
  public:
@@ skipping 55 matching lines @@
   }
 
   TestingOmniboxViewViews* omnibox_view() {
     return omnibox_view_.get();
   }
 
   views::Textfield* omnibox_textfield() {
     return omnibox_view();
   }
 
+  ui::TextEditCommand scheduled_text_edit_command() const {
+    return test_api_->scheduled_text_edit_command();
+  }
+
+  bool OnKeyPressed(const ui::KeyEvent& event) {
+    return test_api_->OnKeyPressed(event);
+  }
+
  private:
   // testing::Test:
   void SetUp() override {
 #if defined(OS_CHROMEOS)
     chromeos::input_method::InitializeForTesting(
         new chromeos::input_method::MockInputMethodManager);
 #endif
     omnibox_view_.reset(new TestingOmniboxViewViews(
         &omnibox_edit_controller_, &profile_, &command_updater_));
+    test_api_.reset(new views::TextfieldTestApi(omnibox_view_.get()));
     omnibox_view_->Init();
   }
 
   void TearDown() override {
     omnibox_view_.reset();
 #if defined(OS_CHROMEOS)
     chromeos::input_method::Shutdown();
 #endif
   }
 
   content::TestBrowserThreadBundle thread_bundle_;
   TestingProfile profile_;
   CommandUpdater command_updater_;
   TestingOmniboxEditController omnibox_edit_controller_;
   std::unique_ptr<TestingOmniboxViewViews> omnibox_view_;
+  std::unique_ptr<views::TextfieldTestApi> test_api_;
+
+  DISALLOW_COPY_AND_ASSIGN(OmniboxViewViewsTest);
 };
 
 // Checks that a single change of the text in the omnibox invokes
 // only one call to OmniboxViewViews::UpdatePopup().
 TEST_F(OmniboxViewViewsTest, UpdatePopupCall) {
   ui::KeyEvent char_event(ui::ET_KEY_PRESSED, ui::VKEY_A, ui::DomCode::US_A, 0,
                           ui::DomKey::FromCharacter('a'),
                           ui::EventTimeForNow());
   omnibox_textfield()->InsertChar(char_event);
   omnibox_view()->CheckUpdatePopupCallInfo(
       1, base::ASCIIToUTF16("a"), gfx::Range(1));
 
   char_event =
       ui::KeyEvent(ui::ET_KEY_PRESSED, ui::VKEY_B, ui::DomCode::US_B, 0,
                    ui::DomKey::FromCharacter('b'), ui::EventTimeForNow());
   omnibox_textfield()->InsertChar(char_event);
   omnibox_view()->CheckUpdatePopupCallInfo(
       2, base::ASCIIToUTF16("ab"), gfx::Range(2));
 
   ui::KeyEvent pressed(ui::ET_KEY_PRESSED, ui::VKEY_BACK, 0);
-  omnibox_textfield()->OnKeyPressed(pressed);
+  OnKeyPressed(pressed);
   omnibox_view()->CheckUpdatePopupCallInfo(
       3, base::ASCIIToUTF16("a"), gfx::Range(1));
 }
+
+// Test that the scheduled text edit command is cleared when
+// Textfield::OnKeyPressed is invoked. This ensures that the scheduled text edit
+// command property is always in the correct state. Test for
+// http://crbug.com/613948.
+TEST_F(OmniboxViewViewsTest, ScheduledTextEditCommand) {
+  omnibox_textfield()->SetTextEditCommandForNextKeyEvent(
+      ui::TextEditCommand::MOVE_UP);
+  EXPECT_EQ(ui::TextEditCommand::MOVE_UP, scheduled_text_edit_command());
+
+  ui::KeyEvent up_pressed(ui::ET_KEY_PRESSED, ui::VKEY_UP, 0);
+  OnKeyPressed(up_pressed);
+  EXPECT_EQ(ui::TextEditCommand::INVALID_COMMAND,
+            scheduled_text_edit_command());
+}