MacViewsBrowser: Fix omnibox crash due to failed DCHECK.

MacViewsBrowser: Fix omnibox crash due to failed DCHECK.

Textfield::SetTextEditCommandForNextKeyEvent can be used to schedule a text
editing command to be executed on the next key press. However, Textfield
subclasses like OmniboxViewViews are currently oblivious to the scheduled text
edit command accounting. When a key press event is handled in
OmnboxViewViews::OnKeyPressed itself, the scheduled_text_edit_command_ property
in Textfield is not cleared, leading to a failed DCHECK when
Textfield::SetTextEditCommandForNextKeyEvent is invoked next.

This CL resolves the crash by prohibiting Textfield subclasses from overriding
OnKeyPressed/Released. This allows Textfield to handle the accounting related to
the scheduled text edit command. This necessiates moving all the
OmniboxViewViews::OnKeyPressed and OmniboxViewViews::OnKeyReleased logic to
OmniboxViewViews::HandleKeyEvent. A test is also added which fails on the
current master.

BUG=613948
TEST=Build with mac_views_browser=1. In the browser, go to the omnibox and type
a partial url such that there are atleast 2 autocomplete suggestions. Press
arrow down key twice. Ensure the browser does not crash.

Committed: https://crrev.com/f588a5a9734fec75adfd7815190d930f0ba13df4
Cr-Commit-Position: refs/heads/master@{#415156}

[karandeepb, 2016-08-25 05:22:32]

The CQ bit was checked by karandeepb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 05:22:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[karandeepb, 2016-08-25 06:11:54]

Patchset #2 (id:20001) has been deleted

[karandeepb, 2016-08-25 06:55:56]

Patchset #3 (id:60001) has been deleted

[karandeepb, 2016-08-25 07:03:35]

Patchset #4 (id:100001) has been deleted

[karandeepb, 2016-08-25 08:36:37]

Description was changed from

==========
Omnibox crash.
==========

to

==========
MacViewsBrowser: Fix omnibox crash due to failed DCHECK.

Textfield::SetTextEditCommandForNextKeyEvent can be used to schedule a text
editing command to be executed on the next key press. However, Textfield
subclasses like OmniboxViewViews are currently oblivious to the scheduled text
edit command accounting. When a key press event is handled in
OmnboxViewViews::OnKeyPressed itself, the scheduled_text_edit_command_ property
in Textfield is not cleared, leading to a failed DCHECK when
Textfield::SetTextEditCommandForNextKeyEvent is invoked next.

This CL resolves the crash by prohibiting Textfield subclasses from overriding
OnKeyPressed/Released. This allows Textfield to handle the accounting related to
the
scheduled text edit command. This necessiates moving all the
OmniboxViewViews::OnKeyPressed and OmniboxViewViews::OnKeyReleased logic to
OmniboxViewViews::HandleKeyEvent.

BUG=613948
==========

[karandeepb, 2016-08-25 08:36:53]

Description was changed from

==========
MacViewsBrowser: Fix omnibox crash due to failed DCHECK.

Textfield::SetTextEditCommandForNextKeyEvent can be used to schedule a text
editing command to be executed on the next key press. However, Textfield
subclasses like OmniboxViewViews are currently oblivious to the scheduled text
edit command accounting. When a key press event is handled in
OmnboxViewViews::OnKeyPressed itself, the scheduled_text_edit_command_ property
in Textfield is not cleared, leading to a failed DCHECK when
Textfield::SetTextEditCommandForNextKeyEvent is invoked next.

This CL resolves the crash by prohibiting Textfield subclasses from overriding
OnKeyPressed/Released. This allows Textfield to handle the accounting related to
the
scheduled text edit command. This necessiates moving all the
OmniboxViewViews::OnKeyPressed and OmniboxViewViews::OnKeyReleased logic to
OmniboxViewViews::HandleKeyEvent.

BUG=613948
==========

to

==========
MacViewsBrowser: Fix omnibox crash due to failed DCHECK.

Textfield::SetTextEditCommandForNextKeyEvent can be used to schedule a text
editing command to be executed on the next key press. However, Textfield
subclasses like OmniboxViewViews are currently oblivious to the scheduled text
edit command accounting. When a key press event is handled in
OmnboxViewViews::OnKeyPressed itself, the scheduled_text_edit_command_ property
in Textfield is not cleared, leading to a failed DCHECK when
Textfield::SetTextEditCommandForNextKeyEvent is invoked next.

This CL resolves the crash by prohibiting Textfield subclasses from overriding
OnKeyPressed/Released. This allows Textfield to handle the accounting related to
the scheduled text edit command. This necessiates moving all the
OmniboxViewViews::OnKeyPressed and OmniboxViewViews::OnKeyReleased logic to
OmniboxViewViews::HandleKeyEvent.

BUG=613948
==========

[karandeepb, 2016-08-25 09:40:14]

Description was changed from

==========
MacViewsBrowser: Fix omnibox crash due to failed DCHECK.

Textfield::SetTextEditCommandForNextKeyEvent can be used to schedule a text
editing command to be executed on the next key press. However, Textfield
subclasses like OmniboxViewViews are currently oblivious to the scheduled text
edit command accounting. When a key press event is handled in
OmnboxViewViews::OnKeyPressed itself, the scheduled_text_edit_command_ property
in Textfield is not cleared, leading to a failed DCHECK when
Textfield::SetTextEditCommandForNextKeyEvent is invoked next.

This CL resolves the crash by prohibiting Textfield subclasses from overriding
OnKeyPressed/Released. This allows Textfield to handle the accounting related to
the scheduled text edit command. This necessiates moving all the
OmniboxViewViews::OnKeyPressed and OmniboxViewViews::OnKeyReleased logic to
OmniboxViewViews::HandleKeyEvent.

BUG=613948
==========

to

==========
MacViewsBrowser: Fix omnibox crash due to failed DCHECK.

Textfield::SetTextEditCommandForNextKeyEvent can be used to schedule a text
editing command to be executed on the next key press. However, Textfield
subclasses like OmniboxViewViews are currently oblivious to the scheduled text
edit command accounting. When a key press event is handled in
OmnboxViewViews::OnKeyPressed itself, the scheduled_text_edit_command_ property
in Textfield is not cleared, leading to a failed DCHECK when
Textfield::SetTextEditCommandForNextKeyEvent is invoked next.

This CL resolves the crash by prohibiting Textfield subclasses from overriding
OnKeyPressed/Released. This allows Textfield to handle the accounting related to
the scheduled text edit command. This necessiates moving all the
OmniboxViewViews::OnKeyPressed and OmniboxViewViews::OnKeyReleased logic to
OmniboxViewViews::HandleKeyEvent. A test is also added which fails on the 
current master.

BUG=613948
==========

[karandeepb, 2016-08-25 09:50:51]

Description was changed from

==========
MacViewsBrowser: Fix omnibox crash due to failed DCHECK.

Textfield::SetTextEditCommandForNextKeyEvent can be used to schedule a text
editing command to be executed on the next key press. However, Textfield
subclasses like OmniboxViewViews are currently oblivious to the scheduled text
edit command accounting. When a key press event is handled in
OmnboxViewViews::OnKeyPressed itself, the scheduled_text_edit_command_ property
in Textfield is not cleared, leading to a failed DCHECK when
Textfield::SetTextEditCommandForNextKeyEvent is invoked next.

This CL resolves the crash by prohibiting Textfield subclasses from overriding
OnKeyPressed/Released. This allows Textfield to handle the accounting related to
the scheduled text edit command. This necessiates moving all the
OmniboxViewViews::OnKeyPressed and OmniboxViewViews::OnKeyReleased logic to
OmniboxViewViews::HandleKeyEvent. A test is also added which fails on the 
current master.

BUG=613948
==========

to

==========
PTAL msw@. This changes the codepaths for key events as far as omnibox is
concerned. Particularly, HandleEarlyTabActions is now called before
Textfield::OnKeyPressed. 



MacViewsBrowser: Fix omnibox crash due to failed DCHECK.

Textfield::SetTextEditCommandForNextKeyEvent can be used to schedule a text
editing command to be executed on the next key press. However, Textfield
subclasses like OmniboxViewViews are currently oblivious to the scheduled text
edit command accounting. When a key press event is handled in
OmnboxViewViews::OnKeyPressed itself, the scheduled_text_edit_command_ property
in Textfield is not cleared, leading to a failed DCHECK when
Textfield::SetTextEditCommandForNextKeyEvent is invoked next.

This CL resolves the crash by prohibiting Textfield subclasses from overriding
OnKeyPressed/Released. This allows Textfield to handle the accounting related to
the scheduled text edit command. This necessiates moving all the
OmniboxViewViews::OnKeyPressed and OmniboxViewViews::OnKeyReleased logic to
OmniboxViewViews::HandleKeyEvent. A test is also added which fails on the 
current master.

BUG=613948
TEST=Build with mac_views_browser=1. In the browser, go to the omnibox and type
a partial url such that there are atleast 2 autocomplete suggestions. Press
arrow down key twice. Ensure the browser does not crash.
==========

[karandeepb, 2016-08-25 09:51:04]

Description was changed from

==========
PTAL msw@. This changes the codepaths for key events as far as omnibox is
concerned. Particularly, HandleEarlyTabActions is now called before
Textfield::OnKeyPressed. 



MacViewsBrowser: Fix omnibox crash due to failed DCHECK.

Textfield::SetTextEditCommandForNextKeyEvent can be used to schedule a text
editing command to be executed on the next key press. However, Textfield
subclasses like OmniboxViewViews are currently oblivious to the scheduled text
edit command accounting. When a key press event is handled in
OmnboxViewViews::OnKeyPressed itself, the scheduled_text_edit_command_ property
in Textfield is not cleared, leading to a failed DCHECK when
Textfield::SetTextEditCommandForNextKeyEvent is invoked next.

This CL resolves the crash by prohibiting Textfield subclasses from overriding
OnKeyPressed/Released. This allows Textfield to handle the accounting related to
the scheduled text edit command. This necessiates moving all the
OmniboxViewViews::OnKeyPressed and OmniboxViewViews::OnKeyReleased logic to
OmniboxViewViews::HandleKeyEvent. A test is also added which fails on the 
current master.

BUG=613948
TEST=Build with mac_views_browser=1. In the browser, go to the omnibox and type
a partial url such that there are atleast 2 autocomplete suggestions. Press
arrow down key twice. Ensure the browser does not crash.
==========

to

==========
MacViewsBrowser: Fix omnibox crash due to failed DCHECK.

Textfield::SetTextEditCommandForNextKeyEvent can be used to schedule a text
editing command to be executed on the next key press. However, Textfield
subclasses like OmniboxViewViews are currently oblivious to the scheduled text
edit command accounting. When a key press event is handled in
OmnboxViewViews::OnKeyPressed itself, the scheduled_text_edit_command_ property
in Textfield is not cleared, leading to a failed DCHECK when
Textfield::SetTextEditCommandForNextKeyEvent is invoked next.

This CL resolves the crash by prohibiting Textfield subclasses from overriding
OnKeyPressed/Released. This allows Textfield to handle the accounting related to
the scheduled text edit command. This necessiates moving all the
OmniboxViewViews::OnKeyPressed and OmniboxViewViews::OnKeyReleased logic to
OmniboxViewViews::HandleKeyEvent. A test is also added which fails on the 
current master.

BUG=613948
TEST=Build with mac_views_browser=1. In the browser, go to the omnibox and type
a partial url such that there are atleast 2 autocomplete suggestions. Press
arrow down key twice. Ensure the browser does not crash.
==========

[karandeepb, 2016-08-25 09:52:10]

Patchset #4 (id:120001) has been deleted

[karandeepb, 2016-08-25 09:52:19]

Patchset #4 (id:140001) has been deleted

[karandeepb, 2016-08-25 10:02:56]

The CQ bit was checked by karandeepb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 10:03:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[karandeepb, 2016-08-25 10:03:52]

karandeepb@chromium.org changed reviewers:
+ msw@chromium.org

[karandeepb, 2016-08-25 10:03:53]

PTAL msw@. This changes the codepaths for key events as far as omnibox is
concerned. For eg., OmniboxViewViews::HandleEarlyTabActions is now called before
Textfield::OnKeyPressed. But don't think it should matter.

You can also see the bug report for more context.

https://codereview.chromium.org/2273263002/diff/1/chrome/browser/ui/views/omn...
File chrome/browser/ui/views/omnibox/omnibox_view_views.cc (left):

https://codereview.chromium.org/2273263002/diff/1/chrome/browser/ui/views/omn...
chrome/browser/ui/views/omnibox/omnibox_view_views.cc:776: return
views::Textfield::OnKeyPressed(event) || HandleEarlyTabActions(event);
Any reason why this wasn't 
HandleEarlyTabActions(event) || views::Textfield::OnKeyPressed(event)?

https://codereview.chromium.org/2273263002/diff/1/chrome/browser/ui/views/omn...
File chrome/browser/ui/views/omnibox/omnibox_view_views.cc (right):

https://codereview.chromium.org/2273263002/diff/1/chrome/browser/ui/views/omn...
chrome/browser/ui/views/omnibox/omnibox_view_views.cc:897:
delete_at_end_pressed_ = false;
Can't seem to find any callers for OmniboxView::DeleteAtEndPressed, maybe it
should be removed?

[commit-bot: I haz the power, 2016-08-25 11:28:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 11:28:34]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[msw, 2016-08-25 17:02:51]

lgtm

https://codereview.chromium.org/2273263002/diff/160001/chrome/browser/ui/view...
File chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc (right):

https://codereview.chromium.org/2273263002/diff/160001/chrome/browser/ui/view...
chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc:155: //
Textfield::OnKeyPressed is invoked. Test for http://crbug.com/613948.
nit: maybe explain why this matters?

https://codereview.chromium.org/2273263002/diff/160001/ui/views/controls/text...
File ui/views/controls/textfield/textfield.h (right):

https://codereview.chromium.org/2273263002/diff/160001/ui/views/controls/text...
ui/views/controls/textfield/textfield.h:216: // OnKey[Pressed/Released] are
virtual only so that they can be overridden in
Can we move these to protected (or private and friend the test sublcasses)?

[karandeepb, 2016-08-26 01:41:42]

The CQ bit was checked by karandeepb@chromium.org

[karandeepb, 2016-08-26 01:41:42]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2273263002/#ps180001
(title: "Address review.")

[karandeepb, 2016-08-26 01:41:44]

The CQ bit was unchecked by karandeepb@chromium.org

[karandeepb, 2016-08-26 01:41:57]

https://codereview.chromium.org/2273263002/diff/160001/chrome/browser/ui/view...
File chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc (right):

https://codereview.chromium.org/2273263002/diff/160001/chrome/browser/ui/view...
chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc:155: //
Textfield::OnKeyPressed is invoked. Test for http://crbug.com/613948.
On 2016/08/25 17:02:51, msw wrote:
> nit: maybe explain why this matters?

Done.

https://codereview.chromium.org/2273263002/diff/160001/ui/views/controls/text...
File ui/views/controls/textfield/textfield.h (right):

https://codereview.chromium.org/2273263002/diff/160001/ui/views/controls/text...
ui/views/controls/textfield/textfield.h:216: // OnKey[Pressed/Released] are
virtual only so that they can be overridden in
On 2016/08/25 17:02:51, msw wrote:
> Can we move these to protected (or private and friend the test sublcasses)?

Moved to private. Had to move TestTextfield out of the anon. namespace.

[karandeepb, 2016-08-26 01:42:10]

The CQ bit was checked by karandeepb@chromium.org

[commit-bot: I haz the power, 2016-08-26 01:42:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 01:56:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 01:56:45]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[karandeepb, 2016-08-26 03:59:13]

The CQ bit was checked by karandeepb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 03:59:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 04:11:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 04:11:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[karandeepb, 2016-08-26 04:22:00]

The CQ bit was checked by karandeepb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 04:22:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[karandeepb, 2016-08-26 04:59:45]

Patchset #6 (id:200001) has been deleted

[commit-bot: I haz the power, 2016-08-26 05:13:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 05:13:55]

Dry run: This issue passed the CQ dry run.

[karandeepb, 2016-08-26 05:15:54]

karandeepb@chromium.org changed reviewers:
+ calamity@chromium.org

[karandeepb, 2016-08-26 05:15:55]

PTAL Chris for ui/app_list. Thanks.

[calamity, 2016-08-26 05:57:51]

app_list lgtm

[karandeepb, 2016-08-26 06:23:03]

PTAL msw@. Let me know if you have any more comments, else I'll land.

[msw, 2016-08-26 07:09:43]

https://codereview.chromium.org/2273263002/diff/220001/ui/views/controls/text...
File ui/views/controls/textfield/textfield_test_api.h (right):

https://codereview.chromium.org/2273263002/diff/220001/ui/views/controls/text...
ui/views/controls/textfield/textfield_test_api.h:40: bool OnKeyPressed(const
ui::KeyEvent& event) {
Can tests instead call Textfield/View::OnKeyEvent(KeyEvent* event) or something
similar, perhaps by static_cast'ing if really needed? It'd be nice to avoid test
api for simply posting events (versus overriding these methods).

[karandeepb, 2016-08-26 08:54:17]

The CQ bit was checked by karandeepb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 08:54:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 10:01:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 10:01:37]

Dry run: This issue passed the CQ dry run.

[karandeepb, 2016-08-26 10:05:16]

PTAL msw@.

https://codereview.chromium.org/2273263002/diff/220001/ui/views/controls/text...
File ui/views/controls/textfield/textfield_test_api.h (right):

https://codereview.chromium.org/2273263002/diff/220001/ui/views/controls/text...
ui/views/controls/textfield/textfield_test_api.h:40: bool OnKeyPressed(const
ui::KeyEvent& event) {
On 2016/08/26 07:09:43, msw wrote:
> Can tests instead call Textfield/View::OnKeyEvent(KeyEvent* event) or
something
> similar, perhaps by static_cast'ing if really needed? It'd be nice to avoid
test
> api for simply posting events (versus overriding these methods).

Done.

[msw, 2016-08-26 15:14:37]

lgtm

[msw, 2016-08-26 15:19:10]

https://codereview.chromium.org/2273263002/diff/240001/ui/views/controls/text...
File ui/views/controls/textfield/textfield_unittest.cc (right):

https://codereview.chromium.org/2273263002/diff/240001/ui/views/controls/text...
ui/views/controls/textfield/textfield_unittest.cc:332: bool OnKeyPressed(const
ui::KeyEvent& e) override {
Oh, can these override onkeyevent instead? and then drop the friend class
mention in rendertext.

[karandeepb, 2016-08-29 03:42:13]

Patchset #8 (id:260001) has been deleted

[karandeepb, 2016-08-29 03:42:26]

The CQ bit was checked by karandeepb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 03:42:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 05:30:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 05:30:05]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[karandeepb, 2016-08-29 09:59:34]

PTAL msw@ in case you have any more comments.

https://codereview.chromium.org/2273263002/diff/240001/ui/views/controls/text...
File ui/views/controls/textfield/textfield_unittest.cc (right):

https://codereview.chromium.org/2273263002/diff/240001/ui/views/controls/text...
ui/views/controls/textfield/textfield_unittest.cc:332: bool OnKeyPressed(const
ui::KeyEvent& e) override {
On 2016/08/26 15:19:09, msw wrote:
> Oh, can these override onkeyevent instead? and then drop the friend class
> mention in rendertext.

Done. Keep forgetting about OnKeyEvent. This also enabled making
Textfield::OnKeyPressed/Released final.

[msw, 2016-08-29 16:59:12]

lgtm

[karandeepb, 2016-08-30 00:19:44]

The CQ bit was checked by karandeepb@chromium.org

[karandeepb, 2016-08-30 00:19:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
calamity@chromium.org
Link to the patchset: https://codereview.chromium.org/2273263002/#ps280001
(title: "Address review, make Textfield::OnKeyPressed/Released final.")

[commit-bot: I haz the power, 2016-08-30 00:53:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 05:28:37]

Description was changed from

==========
MacViewsBrowser: Fix omnibox crash due to failed DCHECK.

Textfield::SetTextEditCommandForNextKeyEvent can be used to schedule a text
editing command to be executed on the next key press. However, Textfield
subclasses like OmniboxViewViews are currently oblivious to the scheduled text
edit command accounting. When a key press event is handled in
OmnboxViewViews::OnKeyPressed itself, the scheduled_text_edit_command_ property
in Textfield is not cleared, leading to a failed DCHECK when
Textfield::SetTextEditCommandForNextKeyEvent is invoked next.

This CL resolves the crash by prohibiting Textfield subclasses from overriding
OnKeyPressed/Released. This allows Textfield to handle the accounting related to
the scheduled text edit command. This necessiates moving all the
OmniboxViewViews::OnKeyPressed and OmniboxViewViews::OnKeyReleased logic to
OmniboxViewViews::HandleKeyEvent. A test is also added which fails on the 
current master.

BUG=613948
TEST=Build with mac_views_browser=1. In the browser, go to the omnibox and type
a partial url such that there are atleast 2 autocomplete suggestions. Press
arrow down key twice. Ensure the browser does not crash.
==========

to

==========
MacViewsBrowser: Fix omnibox crash due to failed DCHECK.

Textfield::SetTextEditCommandForNextKeyEvent can be used to schedule a text
editing command to be executed on the next key press. However, Textfield
subclasses like OmniboxViewViews are currently oblivious to the scheduled text
edit command accounting. When a key press event is handled in
OmnboxViewViews::OnKeyPressed itself, the scheduled_text_edit_command_ property
in Textfield is not cleared, leading to a failed DCHECK when
Textfield::SetTextEditCommandForNextKeyEvent is invoked next.

This CL resolves the crash by prohibiting Textfield subclasses from overriding
OnKeyPressed/Released. This allows Textfield to handle the accounting related to
the scheduled text edit command. This necessiates moving all the
OmniboxViewViews::OnKeyPressed and OmniboxViewViews::OnKeyReleased logic to
OmniboxViewViews::HandleKeyEvent. A test is also added which fails on the 
current master.

BUG=613948
TEST=Build with mac_views_browser=1. In the browser, go to the omnibox and type
a partial url such that there are atleast 2 autocomplete suggestions. Press
arrow down key twice. Ensure the browser does not crash.
==========

[commit-bot: I haz the power, 2016-08-30 05:28:38]

Committed patchset #8 (id:280001)

[commit-bot: I haz the power, 2016-08-30 05:31:22]

Description was changed from

==========
MacViewsBrowser: Fix omnibox crash due to failed DCHECK.

Textfield::SetTextEditCommandForNextKeyEvent can be used to schedule a text
editing command to be executed on the next key press. However, Textfield
subclasses like OmniboxViewViews are currently oblivious to the scheduled text
edit command accounting. When a key press event is handled in
OmnboxViewViews::OnKeyPressed itself, the scheduled_text_edit_command_ property
in Textfield is not cleared, leading to a failed DCHECK when
Textfield::SetTextEditCommandForNextKeyEvent is invoked next.

This CL resolves the crash by prohibiting Textfield subclasses from overriding
OnKeyPressed/Released. This allows Textfield to handle the accounting related to
the scheduled text edit command. This necessiates moving all the
OmniboxViewViews::OnKeyPressed and OmniboxViewViews::OnKeyReleased logic to
OmniboxViewViews::HandleKeyEvent. A test is also added which fails on the 
current master.

BUG=613948
TEST=Build with mac_views_browser=1. In the browser, go to the omnibox and type
a partial url such that there are atleast 2 autocomplete suggestions. Press
arrow down key twice. Ensure the browser does not crash.
==========

to

==========
MacViewsBrowser: Fix omnibox crash due to failed DCHECK.

Textfield::SetTextEditCommandForNextKeyEvent can be used to schedule a text
editing command to be executed on the next key press. However, Textfield
subclasses like OmniboxViewViews are currently oblivious to the scheduled text
edit command accounting. When a key press event is handled in
OmnboxViewViews::OnKeyPressed itself, the scheduled_text_edit_command_ property
in Textfield is not cleared, leading to a failed DCHECK when
Textfield::SetTextEditCommandForNextKeyEvent is invoked next.

This CL resolves the crash by prohibiting Textfield subclasses from overriding
OnKeyPressed/Released. This allows Textfield to handle the accounting related to
the scheduled text edit command. This necessiates moving all the
OmniboxViewViews::OnKeyPressed and OmniboxViewViews::OnKeyReleased logic to
OmniboxViewViews::HandleKeyEvent. A test is also added which fails on the
current master.

BUG=613948
TEST=Build with mac_views_browser=1. In the browser, go to the omnibox and type
a partial url such that there are atleast 2 autocomplete suggestions. Press
arrow down key twice. Ensure the browser does not crash.

Committed: https://crrev.com/f588a5a9734fec75adfd7815190d930f0ba13df4
Cr-Commit-Position: refs/heads/master@{#415156}
==========

[commit-bot: I haz the power, 2016-08-30 05:31:24]

Patchset 8 (id:??) landed as
https://crrev.com/f588a5a9734fec75adfd7815190d930f0ba13df4
Cr-Commit-Position: refs/heads/master@{#415156}