Cleanup overloads of isSpellCheckingEnabledFor

Cleanup overloads of isSpellCheckingEnabledFor

This patch cleans up the two overloads of the function as follows:

SpellChecker::isSpellCheckingEnabledFor(const VisibleSelection&) is changed
into a static function in SpellChecker.cpp since it does not have call site
outside SpellChecker.

SpellChecker::isSpellCheckingEnabledFor(const Node*) is absorbed by is wrapper
SpellChecker::isSpellCheckingEnabledInFocusedNode().

BUG=n/a
TEST=n/a; no behavior change

Committed: https://crrev.com/26470a9df2acd9706ee8bcd903cdc07f018cef52
Cr-Commit-Position: refs/heads/master@{#414333}

[Xiaocheng, 2016-08-25 02:54:48]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 02:55:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-08-25 02:58:01]

Description was changed from

==========
Cleanup overloads of isSpellCheckingEnabledFor

BUG=
==========

to

==========
Cleanup overloads of isSpellCheckingEnabledFor

This patch cleans up the two overloads of the function as follows:

SpellChecker::isSpellCheckingEnabledFor(const VisibleSelection&) is changed
into a static function in SpellChecker.cpp since it does not have call site
outside SpellChecker.

SpellChecker::isSpellCheckingEnabledFor(const Node*) is absorbed by is wrapper
SpellChecker::isSpellCheckingEnabledInFocusedNode().

BUG=n/a
TEST=n/a; no behavior change
==========

[commit-bot: I haz the power, 2016-08-25 04:43:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 04:43:12]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-08-25 05:00:43]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-08-25 05:00:43]

PTAL.

[yosin_UTC9, 2016-08-25 05:15:17]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2016-08-25 05:15:18]

lgtm

[commit-bot: I haz the power, 2016-08-25 05:15:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 05:15:53]

This CL has an open dependency (Issue 2273453003 Patch 20001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[Xiaocheng, 2016-08-25 05:43:39]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2016-08-25 05:44:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 05:49:47]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-25 05:52:34]

Description was changed from

==========
Cleanup overloads of isSpellCheckingEnabledFor

This patch cleans up the two overloads of the function as follows:

SpellChecker::isSpellCheckingEnabledFor(const VisibleSelection&) is changed
into a static function in SpellChecker.cpp since it does not have call site
outside SpellChecker.

SpellChecker::isSpellCheckingEnabledFor(const Node*) is absorbed by is wrapper
SpellChecker::isSpellCheckingEnabledInFocusedNode().

BUG=n/a
TEST=n/a; no behavior change
==========

to

==========
Cleanup overloads of isSpellCheckingEnabledFor

This patch cleans up the two overloads of the function as follows:

SpellChecker::isSpellCheckingEnabledFor(const VisibleSelection&) is changed
into a static function in SpellChecker.cpp since it does not have call site
outside SpellChecker.

SpellChecker::isSpellCheckingEnabledFor(const Node*) is absorbed by is wrapper
SpellChecker::isSpellCheckingEnabledInFocusedNode().

BUG=n/a
TEST=n/a; no behavior change

Committed: https://crrev.com/26470a9df2acd9706ee8bcd903cdc07f018cef52
Cr-Commit-Position: refs/heads/master@{#414333}
==========

[commit-bot: I haz the power, 2016-08-25 05:52:35]

Patchset 1 (id:??) landed as
https://crrev.com/26470a9df2acd9706ee8bcd903cdc07f018cef52
Cr-Commit-Position: refs/heads/master@{#414333}