Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2273233002: Remove redundant size member from InterpolableList (Closed)

Created:
4 years, 3 months ago by alancutter (OOO until 2018)
Modified:
4 years, 3 months ago
Reviewers:
Eric Willigers
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant size member from InterpolableList The size of the list can be read from the m_values vector, no need to store the size separately. Committed: https://crrev.com/9b61930c45eabf3d7f263e631c714342f2d4d337 Cr-Commit-Position: refs/heads/master@{#414330}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -20 lines) Patch
M third_party/WebKit/Source/core/animation/InterpolableValue.h View 2 chunks +4 lines, -10 lines 1 comment Download
M third_party/WebKit/Source/core/animation/InterpolableValue.cpp View 5 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
alancutter (OOO until 2018)
4 years, 3 months ago (2016-08-25 02:02:50 UTC) #2
alancutter (OOO until 2018)
https://codereview.chromium.org/2273233002/diff/1/third_party/WebKit/Source/core/animation/InterpolableValue.h File third_party/WebKit/Source/core/animation/InterpolableValue.h (left): https://codereview.chromium.org/2273233002/diff/1/third_party/WebKit/Source/core/animation/InterpolableValue.h#oldcode135 third_party/WebKit/Source/core/animation/InterpolableValue.h:135: DCHECK_LT(position, m_size); These checks are already performed by Vector::at() ...
4 years, 3 months ago (2016-08-25 02:03:53 UTC) #3
Eric Willigers
lgtm
4 years, 3 months ago (2016-08-25 02:15:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2273233002/1
4 years, 3 months ago (2016-08-25 02:39:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 05:41:31 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 05:44:43 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b61930c45eabf3d7f263e631c714342f2d4d337
Cr-Commit-Position: refs/heads/master@{#414330}

Powered by Google App Engine
This is Rietveld 408576698