Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2273203003: Fix channel mapping for 8-ch audio in ffmpeg_aac_bitstream_converter (Closed)

Created:
4 years, 3 months ago by jwalczak
Modified:
4 years, 3 months ago
Reviewers:
kjoswiak, DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix channel mapping for 8-ch audio in ffmpeg_aac_bitstream_converter FFmpeg's AVCodecContext->channels contains "raw number of channels" (e.g. "2" for 2 channels, "8" for 8 channels). The change ensures that: - the value of "8" is correctly mapped to 0b111 ADTS channel config (aka MPEG-4 Channel Configuration), - the value of "7" becomes unsupported. BUG=640610 Committed: https://crrev.com/a5cd9c49bcb56a12f04555cc218c4a940a579a4e Cr-Commit-Position: refs/heads/master@{#414685}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/filters/ffmpeg_aac_bitstream_converter.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
jwalczak
PTAL
4 years, 3 months ago (2016-08-25 14:59:28 UTC) #3
DaleCurtis
lgtm, +original author kjoswiak in case he wants to weigh in.
4 years, 3 months ago (2016-08-25 17:49:34 UTC) #5
DaleCurtis
Thanks for the fix!
4 years, 3 months ago (2016-08-25 17:49:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2273203003/1
4 years, 3 months ago (2016-08-26 08:05:51 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 11:16:38 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 11:18:12 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5cd9c49bcb56a12f04555cc218c4a940a579a4e
Cr-Commit-Position: refs/heads/master@{#414685}

Powered by Google App Engine
This is Rietveld 408576698