Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 22732005: Add the nss/lib/pkcs12 directory from NSS (Mozilla's Network Security Services) to third_party. Th… (Closed)

Created:
7 years, 4 months ago by Bill Hesse
Modified:
7 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add the nss/lib/pkcs12 directory from NSS (Mozilla's Network Security Services) to third_party. This directory is missing from Chromium's copy of NSS. R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=26000

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10998 lines, -0 lines) Patch
A nss_pkcs12/COPYING View 1 chunk +403 lines, -0 lines 0 comments Download
A nss_pkcs12/Makefile View 1 chunk +49 lines, -0 lines 0 comments Download
A nss_pkcs12/README View 1 chunk +18 lines, -0 lines 0 comments Download
A nss_pkcs12/config.mk View 1 chunk +16 lines, -0 lines 0 comments Download
A nss_pkcs12/manifest.mn View 1 chunk +31 lines, -0 lines 0 comments Download
A nss_pkcs12/p12.h View 1 chunk +185 lines, -0 lines 0 comments Download
A nss_pkcs12/p12creat.c View 1 chunk +222 lines, -0 lines 0 comments Download
A nss_pkcs12/p12d.c View 1 chunk +3548 lines, -0 lines 0 comments Download
A nss_pkcs12/p12dec.c View 1 chunk +664 lines, -0 lines 0 comments Download
A nss_pkcs12/p12e.c View 1 chunk +2079 lines, -0 lines 0 comments Download
A nss_pkcs12/p12exp.c View 1 chunk +1378 lines, -0 lines 0 comments Download
A nss_pkcs12/p12local.h View 1 chunk +59 lines, -0 lines 0 comments Download
A nss_pkcs12/p12local.c View 1 chunk +1342 lines, -0 lines 0 comments Download
A nss_pkcs12/p12plcy.h View 1 chunk +25 lines, -0 lines 0 comments Download
A nss_pkcs12/p12plcy.c View 1 chunk +125 lines, -0 lines 0 comments Download
A nss_pkcs12/p12t.h View 1 chunk +155 lines, -0 lines 0 comments Download
A nss_pkcs12/p12tmpl.c View 1 chunk +291 lines, -0 lines 0 comments Download
A nss_pkcs12/pkcs12.h View 1 chunk +42 lines, -0 lines 0 comments Download
A nss_pkcs12/pkcs12t.h View 1 chunk +366 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bill Hesse
This will be committed when (if) https://codereview.chromium.org/21716004/ , adding SecureSocket.importCertificatesWithPrivateKeys, is committed. https://codereview.chromium.org/22732005/ depends on ...
7 years, 4 months ago (2013-08-09 11:21:46 UTC) #1
Søren Gjesse
lgtm
7 years, 4 months ago (2013-08-09 11:35:16 UTC) #2
Bill Hesse
Committed patchset #1 manually as r26000 (presubmit successful).
7 years, 4 months ago (2013-08-12 13:49:57 UTC) #3
Ivan Posva
Is the third_party/nss_pkcs12 directory still needed? Thanks, -Ivan
7 years, 4 months ago (2013-08-22 16:28:20 UTC) #4
Bill Hesse
7 years, 4 months ago (2013-08-22 16:28:56 UTC) #5
Message was sent while issue was closed.
On 2013/08/22 16:28:20, Ivan Posva wrote:
> Is the third_party/nss_pkcs12 directory still needed?
> 
> Thanks,
> -Ivan

No.  I'll remove it.

Powered by Google App Engine
This is Rietveld 408576698