Make compositor_frame.h NOT include base/trace_event/trace_event.h

Make compositor_frame.h NOT include base/trace_event/trace_event.h

This is a prepartory CL to bring compositor_frame.typemap to Blink. There is no
change in behavior except the include paths for compositor_frame.h is trimmed.

Currently, compositor_frame.h indirectly include base/trace_event/trace_event.h
via latency_info.h and resource_format.h (Note that resource_format.h indirectly
include trace_event.h via gpu_memory_buffer.h). Once the compositor_frame.h is
brought to Blink mojom file (which I'm going to do in future CLs), the
trace_event.h will have conflicting macro definition with
third_party/WebKit/Source/platform/TraceEvent.h.

By analyzing latency_info.h and resource_format.h, I find that the trace_event.h
was previously over-included. Therefore, I shifted the problematic included
file from these two header files to their respective cc files. All the rest of
changes in this CL are just results due to this shift to make Chrome compiled.

BUG=629566
TBR=dtrainor@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/180af792f3687b88d9634836e022d86879b8ac73
Cr-Commit-Position: refs/heads/master@{#414828}

[xlai (Olivia), 2016-08-25 00:06:50]

Description was changed from

==========
Make compositor_frame.h NOT include base/trace_event/trace_event.h

This is a prepartory CL to bring compositor_frame.typemap to Blink. There is no
change in behavior except the include paths for compositor_frame.h is trimmed.

Currently, compositor_frame.h indirectly include base/trace_event/trace_event.h
via latency_info.h and resource_format.h (Note that resource_format.h indirectly
include trace_event.h via gpu_memory_buffer.h). Once the compositor_frame.h is
brought to Blink mojom file (which I'm going to do in future CLs), the
trace_event.h will have conflicting macro definition with
third_party/WebKit/Source/platform/TraceEvent.h.

By analyzing latency_info.h and resource_format.h, I find that the trace_event.h
was previously over-included. Therefore, I shifted the problematic included
file from these two header files to their respective cc files. All the rest of
changes in this CL are just results due to this shift to make Chrome compiled.

BUG=629566
==========

to

==========
Make compositor_frame.h NOT include base/trace_event/trace_event.h

This is a prepartory CL to bring compositor_frame.typemap to Blink. There is no
change in behavior except the include paths for compositor_frame.h is trimmed.

Currently, compositor_frame.h indirectly include base/trace_event/trace_event.h
via latency_info.h and resource_format.h (Note that resource_format.h indirectly
include trace_event.h via gpu_memory_buffer.h). Once the compositor_frame.h is
brought to Blink mojom file (which I'm going to do in future CLs), the
trace_event.h will have conflicting macro definition with
third_party/WebKit/Source/platform/TraceEvent.h.

By analyzing latency_info.h and resource_format.h, I find that the trace_event.h
was previously over-included. Therefore, I shifted the problematic included
file from these two header files to their respective cc files. All the rest of
changes in this CL are just results due to this shift to make Chrome compiled.

BUG=629566
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[xlai (Olivia), 2016-08-25 00:07:43]

The CQ bit was checked by xlai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 00:08:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 00:30:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 00:30:55]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xlai (Olivia), 2016-08-25 01:06:16]

The CQ bit was checked by xlai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 01:07:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 01:26:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 01:26:18]

Dry run: Try jobs failed on following builders:
  linux_precise_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_precise_blink_rel/...)

[xlai (Olivia), 2016-08-25 02:43:06]

The CQ bit was checked by xlai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 02:44:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 05:20:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 05:20:54]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[xlai (Olivia), 2016-08-25 14:33:07]

xlai@chromium.org changed reviewers:
+ erg@chromium.org, sadrul@chromium.org, weiliangc@chromium.org

[xlai (Olivia), 2016-08-25 14:33:08]

This CL does not cause behavior change; it 
just trims the #include so that compositor_frame.h does not
indirectly include trace_event.h unnecessarily (that will 
conflict with TraceEvent.h in Blink). This is to
prepare for the future patch that brings compositor_frame 
typemap to Blink.

sadrul@chromium.org: Please review changes in src/ui/ and one small change in
content/browser/renderer_host.

weiliangc@chromium.org: Please review changes in src/cc/.

erg@chromium.org: Please review changes in src/services/ui.


Thanks a lot!

[weiliangc, 2016-08-25 16:51:44]

cc/ LGTM.

[sadrul, 2016-08-25 19:45:15]

https://codereview.chromium.org/2273193002/diff/40001/ui/events/latency_info.h
File ui/events/latency_info.h (right):

https://codereview.chromium.org/2273193002/diff/40001/ui/events/latency_info....
ui/events/latency_info.h:11: #include <queue>
The code in here doesn't seem to actually use queue? Do we need this here?

https://codereview.chromium.org/2273193002/diff/40001/ui/events/latency_info....
ui/events/latency_info.h:19: #include "base/strings/string16.h"
It doesn't look like any of these headers need to be in this file?

[xlai (Olivia), 2016-08-25 20:11:15]

xlai@chromium.org changed reviewers:
+ nasko@chromium.org

[xlai (Olivia), 2016-08-25 20:11:16]

nasko@chromium.org: Please review changes in
ui/events/ipc/latency_info_param_traits.h and content/renderer. This CL just
trims the #include path; no behavior change.

https://codereview.chromium.org/2273193002/diff/40001/ui/events/latency_info.h
File ui/events/latency_info.h (right):

https://codereview.chromium.org/2273193002/diff/40001/ui/events/latency_info....
ui/events/latency_info.h:19: #include "base/strings/string16.h"
On 2016/08/25 19:45:14, sadrul wrote:
> It doesn't look like any of these headers need to be in this file?

I've deleted all these #include files. As a result, these files are added to the
included list in some other files that include latency_info.h and implicitly use
these files.

[xlai (Olivia), 2016-08-25 21:03:03]

Description was changed from

==========
Make compositor_frame.h NOT include base/trace_event/trace_event.h

This is a prepartory CL to bring compositor_frame.typemap to Blink. There is no
change in behavior except the include paths for compositor_frame.h is trimmed.

Currently, compositor_frame.h indirectly include base/trace_event/trace_event.h
via latency_info.h and resource_format.h (Note that resource_format.h indirectly
include trace_event.h via gpu_memory_buffer.h). Once the compositor_frame.h is
brought to Blink mojom file (which I'm going to do in future CLs), the
trace_event.h will have conflicting macro definition with
third_party/WebKit/Source/platform/TraceEvent.h.

By analyzing latency_info.h and resource_format.h, I find that the trace_event.h
was previously over-included. Therefore, I shifted the problematic included
file from these two header files to their respective cc files. All the rest of
changes in this CL are just results due to this shift to make Chrome compiled.

BUG=629566
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Make compositor_frame.h NOT include base/trace_event/trace_event.h

This is a prepartory CL to bring compositor_frame.typemap to Blink. There is no
change in behavior except the include paths for compositor_frame.h is trimmed.

Currently, compositor_frame.h indirectly include base/trace_event/trace_event.h
via latency_info.h and resource_format.h (Note that resource_format.h indirectly
include trace_event.h via gpu_memory_buffer.h). Once the compositor_frame.h is
brought to Blink mojom file (which I'm going to do in future CLs), the
trace_event.h will have conflicting macro definition with
third_party/WebKit/Source/platform/TraceEvent.h.

By analyzing latency_info.h and resource_format.h, I find that the trace_event.h
was previously over-included. Therefore, I shifted the problematic included
file from these two header files to their respective cc files. All the rest of
changes in this CL are just results due to this shift to make Chrome compiled.

BUG=629566
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[xlai (Olivia), 2016-08-25 21:03:03]

xlai@chromium.org changed reviewers:
- nasko@chromium.org

[xlai (Olivia), 2016-08-25 21:07:52]

xlai@chromium.org changed reviewers:
+ sievers@chromium.org, tsepez@chromium.org

[xlai (Olivia), 2016-08-25 21:07:52]

+tsepez@chromium.org: Please review changes in latency_info_param_traits.h.

+sievers@chromium.org: Please review changes in content/

Thanks!

There is no change in behavior. Only include files are trimmed.

[Tom Sepez, 2016-08-25 21:11:49]

RS LGTM on adding include file.

[sadrul, 2016-08-26 00:23:10]

lgtm

https://codereview.chromium.org/2273193002/diff/60001/ui/events/event.h
File ui/events/event.h (right):

https://codereview.chromium.org/2273193002/diff/60001/ui/events/event.h#newco...
ui/events/event.h:17: #include "base/strings/string16.h"
This doesn't seem necessary.

[xlai (Olivia), 2016-08-26 14:59:58]

https://codereview.chromium.org/2273193002/diff/60001/ui/events/event.h
File ui/events/event.h (right):

https://codereview.chromium.org/2273193002/diff/60001/ui/events/event.h#newco...
ui/events/event.h:17: #include "base/strings/string16.h"
On 2016/08/26 00:23:10, sadrul wrote:
> This doesn't seem necessary.

It is necessary. base::char16 is used in various places in this file.

[sadrul, 2016-08-26 15:01:13]

slgtm

https://codereview.chromium.org/2273193002/diff/60001/ui/events/event.h
File ui/events/event.h (right):

https://codereview.chromium.org/2273193002/diff/60001/ui/events/event.h#newco...
ui/events/event.h:17: #include "base/strings/string16.h"
On 2016/08/26 14:59:58, xlai (Olivia) wrote:
> On 2016/08/26 00:23:10, sadrul wrote:
> > This doesn't seem necessary.
> 
> It is necessary. base::char16 is used in various places in this file.

Oh ok. My bad.

[no sievers, 2016-08-26 17:17:34]

content lgtm

[xlai (Olivia), 2016-08-26 17:19:07]

The CQ bit was checked by xlai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 17:19:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 17:26:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 17:26:54]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Elliot Glaysher, 2016-08-26 17:37:59]

services/ui/ iwyu lgtm.

[xlai (Olivia), 2016-08-26 18:31:49]

The CQ bit was checked by xlai@chromium.org to run a CQ dry run

[xlai (Olivia), 2016-08-26 18:33:08]

xlai@chromium.org changed reviewers:
+ dtrainor@chromium.org

[xlai (Olivia), 2016-08-26 18:33:23]

Description was changed from

==========
Make compositor_frame.h NOT include base/trace_event/trace_event.h

This is a prepartory CL to bring compositor_frame.typemap to Blink. There is no
change in behavior except the include paths for compositor_frame.h is trimmed.

Currently, compositor_frame.h indirectly include base/trace_event/trace_event.h
via latency_info.h and resource_format.h (Note that resource_format.h indirectly
include trace_event.h via gpu_memory_buffer.h). Once the compositor_frame.h is
brought to Blink mojom file (which I'm going to do in future CLs), the
trace_event.h will have conflicting macro definition with
third_party/WebKit/Source/platform/TraceEvent.h.

By analyzing latency_info.h and resource_format.h, I find that the trace_event.h
was previously over-included. Therefore, I shifted the problematic included
file from these two header files to their respective cc files. All the rest of
changes in this CL are just results due to this shift to make Chrome compiled.

BUG=629566
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Make compositor_frame.h NOT include base/trace_event/trace_event.h

This is a prepartory CL to bring compositor_frame.typemap to Blink. There is no
change in behavior except the include paths for compositor_frame.h is trimmed.

Currently, compositor_frame.h indirectly include base/trace_event/trace_event.h
via latency_info.h and resource_format.h (Note that resource_format.h indirectly
include trace_event.h via gpu_memory_buffer.h). Once the compositor_frame.h is
brought to Blink mojom file (which I'm going to do in future CLs), the
trace_event.h will have conflicting macro definition with
third_party/WebKit/Source/platform/TraceEvent.h.

By analyzing latency_info.h and resource_format.h, I find that the trace_event.h
was previously over-included. Therefore, I shifted the problematic included
file from these two header files to their respective cc files. All the rest of
changes in this CL are just results due to this shift to make Chrome compiled.

BUG=629566
TBR=dtrainor@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-08-26 18:33:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 18:42:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 18:42:26]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[xlai (Olivia), 2016-08-26 19:58:44]

The CQ bit was checked by xlai@chromium.org

[xlai (Olivia), 2016-08-26 19:58:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
weiliangc@chromium.org, tsepez@chromium.org, erg@chromium.org,
sadrul@chromium.org, sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/2273193002/#ps100001
(title: "Rebase again + presubmit fix")

[commit-bot: I haz the power, 2016-08-26 19:59:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 22:08:04]

Description was changed from

==========
Make compositor_frame.h NOT include base/trace_event/trace_event.h

This is a prepartory CL to bring compositor_frame.typemap to Blink. There is no
change in behavior except the include paths for compositor_frame.h is trimmed.

Currently, compositor_frame.h indirectly include base/trace_event/trace_event.h
via latency_info.h and resource_format.h (Note that resource_format.h indirectly
include trace_event.h via gpu_memory_buffer.h). Once the compositor_frame.h is
brought to Blink mojom file (which I'm going to do in future CLs), the
trace_event.h will have conflicting macro definition with
third_party/WebKit/Source/platform/TraceEvent.h.

By analyzing latency_info.h and resource_format.h, I find that the trace_event.h
was previously over-included. Therefore, I shifted the problematic included
file from these two header files to their respective cc files. All the rest of
changes in this CL are just results due to this shift to make Chrome compiled.

BUG=629566
TBR=dtrainor@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Make compositor_frame.h NOT include base/trace_event/trace_event.h

This is a prepartory CL to bring compositor_frame.typemap to Blink. There is no
change in behavior except the include paths for compositor_frame.h is trimmed.

Currently, compositor_frame.h indirectly include base/trace_event/trace_event.h
via latency_info.h and resource_format.h (Note that resource_format.h indirectly
include trace_event.h via gpu_memory_buffer.h). Once the compositor_frame.h is
brought to Blink mojom file (which I'm going to do in future CLs), the
trace_event.h will have conflicting macro definition with
third_party/WebKit/Source/platform/TraceEvent.h.

By analyzing latency_info.h and resource_format.h, I find that the trace_event.h
was previously over-included. Therefore, I shifted the problematic included
file from these two header files to their respective cc files. All the rest of
changes in this CL are just results due to this shift to make Chrome compiled.

BUG=629566
TBR=dtrainor@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-08-26 22:08:05]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-08-26 22:09:40]

Description was changed from

==========
Make compositor_frame.h NOT include base/trace_event/trace_event.h

This is a prepartory CL to bring compositor_frame.typemap to Blink. There is no
change in behavior except the include paths for compositor_frame.h is trimmed.

Currently, compositor_frame.h indirectly include base/trace_event/trace_event.h
via latency_info.h and resource_format.h (Note that resource_format.h indirectly
include trace_event.h via gpu_memory_buffer.h). Once the compositor_frame.h is
brought to Blink mojom file (which I'm going to do in future CLs), the
trace_event.h will have conflicting macro definition with
third_party/WebKit/Source/platform/TraceEvent.h.

By analyzing latency_info.h and resource_format.h, I find that the trace_event.h
was previously over-included. Therefore, I shifted the problematic included
file from these two header files to their respective cc files. All the rest of
changes in this CL are just results due to this shift to make Chrome compiled.

BUG=629566
TBR=dtrainor@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Make compositor_frame.h NOT include base/trace_event/trace_event.h

This is a prepartory CL to bring compositor_frame.typemap to Blink. There is no
change in behavior except the include paths for compositor_frame.h is trimmed.

Currently, compositor_frame.h indirectly include base/trace_event/trace_event.h
via latency_info.h and resource_format.h (Note that resource_format.h indirectly
include trace_event.h via gpu_memory_buffer.h). Once the compositor_frame.h is
brought to Blink mojom file (which I'm going to do in future CLs), the
trace_event.h will have conflicting macro definition with
third_party/WebKit/Source/platform/TraceEvent.h.

By analyzing latency_info.h and resource_format.h, I find that the trace_event.h
was previously over-included. Therefore, I shifted the problematic included
file from these two header files to their respective cc files. All the rest of
changes in this CL are just results due to this shift to make Chrome compiled.

BUG=629566
TBR=dtrainor@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/180af792f3687b88d9634836e022d86879b8ac73
Cr-Commit-Position: refs/heads/master@{#414828}
==========

[commit-bot: I haz the power, 2016-08-26 22:09:41]

Patchset 6 (id:??) landed as
https://crrev.com/180af792f3687b88d9634836e022d86879b8ac73
Cr-Commit-Position: refs/heads/master@{#414828}