Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2273133002: Use children changed events to monitor active descendant changes. (Closed)

Created:
4 years, 4 months ago by David Tseng
Modified:
4 years, 4 months ago
Reviewers:
nektarios, dmazzoni
CC:
aboxhall+watch_chromium.org, arv+watch_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, nektar+watch_chromium.org, oshima+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use children changed events to monitor active descendant changes. While the backing Blink implementation gets further fleshed out, loosen ChromeVox's output of active descendants by reading it on children change events. The change makes it so that active descendants are read out when: - the focused node (node with state focused), has an active descendant - the incoming event is either children changed or active descendant changed TEST=drive.google.com; tab to one of the popup buttons; up/down arrow reads options. Committed: https://crrev.com/433f8e203fb1304aae9305fc429f176cda57f573 Cr-Commit-Position: refs/heads/master@{#414242}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
David Tseng
We need to make this work with ChromeVox before things get resolved in Blink. Please ...
4 years, 4 months ago (2016-08-24 21:30:43 UTC) #4
dmazzoni
lgtm
4 years, 4 months ago (2016-08-24 22:25:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2273133002/1
4 years, 4 months ago (2016-08-24 22:33:00 UTC) #8
nektarios
lgtm
4 years, 4 months ago (2016-08-24 22:42:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-25 01:11:32 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-25 01:15:05 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/433f8e203fb1304aae9305fc429f176cda57f573
Cr-Commit-Position: refs/heads/master@{#414242}

Powered by Google App Engine
This is Rietveld 408576698