Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2273123003: Add comment to clarify what the mock action in the test does. (Closed)

Created:
4 years, 4 months ago by yamaguchi
Modified:
4 years, 3 months ago
Reviewers:
satorux1
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add comment to clarify what the mock action in the test does. This is a follow-up of Issue 2230713003. BUG=629945, 640579 Committed: https://crrev.com/eb9681e84dffcad3042407c86aa4768e6f321cee Cr-Commit-Position: refs/heads/master@{#414298}

Patch Set 1 #

Patch Set 2 : Minor revision of the comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chromeos/disks/disk_mount_manager_unittest.cc View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
yamaguchi
4 years, 4 months ago (2016-08-25 02:06:23 UTC) #2
satorux1
lgtm. please add the bug number to BUG=
4 years, 3 months ago (2016-08-25 02:22:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2273123003/20001
4 years, 3 months ago (2016-08-25 02:29:50 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-25 03:50:12 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 03:53:56 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eb9681e84dffcad3042407c86aa4768e6f321cee
Cr-Commit-Position: refs/heads/master@{#414298}

Powered by Google App Engine
This is Rietveld 408576698