Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2273123002: Make iOS recipes explicitly set GIT_MODE (Closed)

Created:
4 years, 4 months ago by agable
Modified:
4 years, 4 months ago
Reviewers:
smut, martiniss
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -26 lines) Patch
M scripts/slave/recipe_modules/ios/api.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/ios/example.expected/basic.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/ios/example.expected/clobber.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/ios/example.expected/errors.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/ios/example.expected/expired.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/ios/example.expected/infra_failure.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/ios/example.expected/no_exit_code.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/ios/example.expected/test_failure.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/ios/example.expected/timed_out.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/try.expected/basic.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/try.expected/gn.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/try.expected/gyp_goma.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/try.expected/icu_patch.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/try.expected/parent.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/try.expected/swarming.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/try.expected/swarming_tests_skipped.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/try.expected/without_patch_failure.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/ios/try.expected/without_patch_success.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/ios/unified_builder_tester.expected/basic.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/unified_builder_tester.expected/goma.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/unified_builder_tester.expected/infrastructure_failure.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/unified_builder_tester.expected/multiple_failures.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/unified_builder_tester.expected/no_tests.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/unified_builder_tester.expected/test_failure.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
agable
4 years, 4 months ago (2016-08-24 20:50:56 UTC) #1
martiniss
lgtm
4 years, 4 months ago (2016-08-24 20:55:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2273123002/1
4 years, 4 months ago (2016-08-24 20:58:10 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 21:02:15 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/32a901e0ee458a3b063f...

Powered by Google App Engine
This is Rietveld 408576698