Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: chrome/installer/setup/install.cc

Issue 2273113002: Delete old files after an update. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@harvester
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/installer/util/BUILD.gn » ('j') | chrome/installer/util/delete_old_versions.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/setup/install.cc
diff --git a/chrome/installer/setup/install.cc b/chrome/installer/setup/install.cc
index 4591c8cf347d4ebe279a7b75df1fa00693615343..53109df136ef38f06b1f5674645724dcaca7c774 100644
--- a/chrome/installer/setup/install.cc
+++ b/chrome/installer/setup/install.cc
@@ -32,6 +32,7 @@
#include "chrome/installer/util/browser_distribution.h"
#include "chrome/installer/util/create_reg_key_work_item.h"
#include "chrome/installer/util/delete_after_reboot_helper.h"
+#include "chrome/installer/util/delete_old_versions.h"
#include "chrome/installer/util/google_update_constants.h"
#include "chrome/installer/util/helper.h"
#include "chrome/installer/util/install_util.h"
@@ -679,11 +680,9 @@ InstallStatus InstallOrUpdateProduct(
}
installer_state.SetStage(REMOVING_OLD_VERSIONS);
-
- installer_state.RemoveOldVersionDirectories(
- new_version,
- existing_version.get(),
- install_temp_path);
+ // TODO(fdoray): Launch a cleanup process when this fails during a not-in-
+ // use update. crbug.com/451546
+ DeleteOldVersions(installer_state.target_path());
}
return result;
« no previous file with comments | « no previous file | chrome/installer/util/BUILD.gn » ('j') | chrome/installer/util/delete_old_versions.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698