Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2273103003: [ash-md] Cancels overview mode before switching user profiles (Closed)

Created:
4 years, 4 months ago by varkha
Modified:
4 years, 3 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ash-md] Cancels overview mode before switching user profiles BUG=633580 Committed: https://crrev.com/888ae0b290138fdc505af4a30e75646658b23aa0 Cr-Commit-Position: refs/heads/master@{#414648}

Patch Set 1 #

Patch Set 2 : [ash-md] Cancels overview mode before switching user profiles (test) #

Total comments: 2

Patch Set 3 : [ash-md] Cancels overview mode before switching user profiles (nit) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -2 lines) Patch
M ash/common/wm/overview/window_selector_controller.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/common/wm/overview/window_selector_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/user_switch_util.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/user_switch_util_unittest.cc View 1 2 3 chunks +29 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
varkha
oshima@, can you please take a look? This seems to be the simplest way. Thanks!
4 years, 4 months ago (2016-08-24 20:41:21 UTC) #4
oshima
can you add a test?
4 years, 4 months ago (2016-08-24 23:29:12 UTC) #7
varkha
On 2016/08/24 23:29:12, oshima wrote: > can you add a test? Done.
4 years, 3 months ago (2016-08-25 20:31:59 UTC) #9
oshima
lgtm Thanks! https://codereview.chromium.org/2273103003/diff/20001/chrome/browser/ui/ash/multi_user/user_switch_util_unittest.cc File chrome/browser/ui/ash/multi_user/user_switch_util_unittest.cc (right): https://codereview.chromium.org/2273103003/diff/20001/chrome/browser/ui/ash/multi_user/user_switch_util_unittest.cc#newcode94 chrome/browser/ui/ash/multi_user/user_switch_util_unittest.cc:94: bool IsSelecting() { return window_selector_controller()->IsSelecting(); } nit: ...
4 years, 3 months ago (2016-08-25 21:29:40 UTC) #11
varkha
https://codereview.chromium.org/2273103003/diff/20001/chrome/browser/ui/ash/multi_user/user_switch_util_unittest.cc File chrome/browser/ui/ash/multi_user/user_switch_util_unittest.cc (right): https://codereview.chromium.org/2273103003/diff/20001/chrome/browser/ui/ash/multi_user/user_switch_util_unittest.cc#newcode94 chrome/browser/ui/ash/multi_user/user_switch_util_unittest.cc:94: bool IsSelecting() { return window_selector_controller()->IsSelecting(); } On 2016/08/25 21:29:39, ...
4 years, 3 months ago (2016-08-26 03:28:53 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2273103003/40001
4 years, 3 months ago (2016-08-26 03:29:36 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-08-26 04:15:14 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 04:16:53 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/888ae0b290138fdc505af4a30e75646658b23aa0
Cr-Commit-Position: refs/heads/master@{#414648}

Powered by Google App Engine
This is Rietveld 408576698