Issue 2273103002: Return version of the generated file in GenerateAlternatePEFileVersion.

Issue 2273103002: Return version of the generated file in GenerateAlternatePEFileVersion. (Closed)

Created:
4 years, 4 months ago by fdoray

Modified:
4 years, 3 months ago

Reviewers:
grt (UTC plus 2)

CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, wfh+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Return version of the generated file in GenerateAlternatePEFileVersion. BUG=451546 Committed: https://crrev.com/6f57e3ef88478e247aa9dd512a2341f205668142 Cr-Commit-Position: refs/heads/master@{#414437}

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -44 lines)			Patch
	M	chrome/installer/test/alternate_version_generator.h	View		2 chunks	+10 lines, -8 lines	0 comments	Download
	M	chrome/installer/test/alternate_version_generator.cc	View		11 chunks	+39 lines, -36 lines	0 comments	Download

Dependent Patchsets:

Total messages: 8 (3 generated)

fdoray

PTAL This is a pre-requisite for https://codereview.chromium.org/2273113002/

4 years, 4 months ago (2016-08-24 20:38:47 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2273103002/1

4 years, 3 months ago (2016-08-25 14:00:13 UTC) #5

commit-bot: I haz the power

4 years, 3 months ago (2016-08-25 15:06:46 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/6f57e3ef88478e247aa9dd512a2341f205668142
Cr-Commit-Position: refs/heads/master@{#414437}