Issue 2273043002: bot_update: deploy git fetch timeout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2273043002: bot_update: deploy git fetch timeout. (Closed)

Created:
4 years, 4 months ago by tandrii(chromium)

Modified:
4 years, 2 months ago

Reviewers:
Ryan Tseng, hinoka

CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@kill-fetch

Target Ref:
refs/heads/master

Project:
depot_tools

Visibility:
Public.

More Reviews

Description

bot_update: deploy git fetch timeout. COMMIT=False R=hinoka@chromium.org BUG=635641

Patch Set 1 #

Total comments: 1

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -2 lines)			Patch
M	gclient.py	View	1 chunk	+3 lines, -0 lines	1 comment	Download
M	gclient_scm.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	recipe_modules/bot_update/resources/bot_update.py	View	1 chunk	+2 lines, -1 line	0 comments	Download

Depends on Patchset:

Issue 2241843002 Patch 120001

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

tandrii(chromium)

PTAL - this is how I intend to deploy the timeout after I am certain ...

4 years, 4 months ago (2016-08-24 14:44:17 UTC) #1

Ryan Tseng

4 years, 4 months ago (2016-08-25 00:06:34 UTC) #3

https://codereview.chromium.org/2273043002/diff/1/gclient.py
File gclient.py (right):

https://codereview.chromium.org/2273043002/diff/1/gclient.py#newcode2089
gclient.py:2089: 'fetch command. Default is no deadline.')
nit: actually isn't it time inbetween output

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages