Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 227303004: Added a public function to cancel any fling gestures (Closed)

Created:
6 years, 8 months ago by elisabets
Modified:
6 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Added a public function to cancel any fling gestures BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265808

Patch Set 1 #

Total comments: 1

Patch Set 2 : Moved function cancelFling and added javadoc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
elisabets
6 years, 8 months ago (2014-04-11 12:02:27 UTC) #1
jdduke (slow)
elisabets@: Is there a particular bug/issue associated with this addition? Or would this be wired ...
6 years, 8 months ago (2014-04-11 14:53:23 UTC) #2
elisabets
On 2014/04/11 14:53:23, jdduke wrote: > elisabets@: Is there a particular bug/issue associated with this ...
6 years, 8 months ago (2014-04-14 05:51:43 UTC) #3
jdduke (slow)
I think it's a fine addition, just wanted to understand the use-case. So you listen ...
6 years, 8 months ago (2014-04-14 14:45:55 UTC) #4
jdduke (slow)
Oops, sorry I missed that you had updated the patch (reviewers don't get notifications when ...
6 years, 8 months ago (2014-04-21 16:43:28 UTC) #5
elisabets
The CQ bit was checked by elisabets@opera.com
6 years, 8 months ago (2014-04-22 08:16:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/elisabets@opera.com/227303004/20001
6 years, 8 months ago (2014-04-22 08:16:13 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-22 09:12:05 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-22 09:12:05 UTC) #9
elisabets
The CQ bit was checked by elisabets@opera.com
6 years, 8 months ago (2014-04-22 10:48:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/elisabets@opera.com/227303004/20001
6 years, 8 months ago (2014-04-22 10:48:30 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-22 11:38:16 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-22 11:38:17 UTC) #13
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 8 months ago (2014-04-23 23:05:20 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/elisabets@opera.com/227303004/20001
6 years, 8 months ago (2014-04-23 23:05:44 UTC) #15
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 01:16:48 UTC) #16
Message was sent while issue was closed.
Change committed as 265808

Powered by Google App Engine
This is Rietveld 408576698