[modules] Split exports into regular and special, store regular ones in a multimap.

[modules] Split exports into regular and special, store regular ones in a multimap.

BUG=v8:1569
Committed: https://crrev.com/6e67d042601bb6773c7a73dc3e290bdb50b4e68e
Cr-Commit-Position: refs/heads/master@{#38889}

[neis, 2016-08-24 14:42:14]

Description was changed from

==========
Split exports into regular and special, use multimap for regular.

BUG=
==========

to

==========
[modules] Split exports into regular and special, use multimap for regular.

BUG=v8:1569
==========

[neis, 2016-08-24 14:42:14]

neis@chromium.org changed reviewers:
+ adamk@chromium.org

[neis, 2016-08-24 14:46:04]

PTAL.

https://codereview.chromium.org/2273013002/diff/20001/src/ast/modules.cc
File src/ast/modules.cc (right):

https://codereview.chromium.org/2273013002/diff/20001/src/ast/modules.cc#newc...
src/ast/modules.cc:108: ZoneSet<const AstRawString*> export_names(zone);
For simplicity, I'm now using a ZoneSet here rather than a ZoneHashMap.

https://codereview.chromium.org/2273013002/diff/20001/test/cctest/test-parsin...
File test/cctest/test-parsing.cc (right):

https://codereview.chromium.org/2273013002/diff/20001/test/cctest/test-parsin...
test/cctest/test-parsing.cc:5855:
CHECK(entry->export_name->IsOneByteEqualTo(export_name));
!!!

[neis, 2016-08-24 14:46:44]

Description was changed from

==========
[modules] Split exports into regular and special, use multimap for regular.

BUG=v8:1569
==========

to

==========
[modules] Split exports into regular and special, store regular ones in a
multimap.

BUG=v8:1569
==========

[neis, 2016-08-24 15:03:26]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 15:03:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 15:08:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 15:08:44]

Dry run: Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/22489)

[adamk, 2016-08-24 18:06:09]

lgtm

https://codereview.chromium.org/2273013002/diff/20001/src/ast/modules.h
File src/ast/modules.h (right):

https://codereview.chromium.org/2273013002/diff/20001/src/ast/modules.h#newco...
src/ast/modules.h:112: ZoneList<const ModuleEntry*> special_imports_;
Maybe add a TODO to use ZoneVector for these so that this is all STL?

https://codereview.chromium.org/2273013002/diff/20001/test/cctest/test-parsin...
File test/cctest/test-parsing.cc (right):

https://codereview.chromium.org/2273013002/diff/20001/test/cctest/test-parsin...
test/cctest/test-parsing.cc:5855:
CHECK(entry->export_name->IsOneByteEqualTo(export_name));
On 2016/08/24 14:46:04, neis wrote:
> !!!

Ha!

[neis, 2016-08-25 08:01:38]

The CQ bit was checked by neis@chromium.org

[neis, 2016-08-25 08:01:39]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/2273013002/#ps40001
(title: "Add TODO.")

[commit-bot: I haz the power, 2016-08-25 08:01:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 08:06:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 08:06:33]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/22550)

[neis, 2016-08-25 08:08:36]

The CQ bit was checked by neis@chromium.org

[neis, 2016-08-25 08:08:36]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/2273013002/#ps60001
(title: "git cl format")

[commit-bot: I haz the power, 2016-08-25 08:08:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 08:37:15]

Description was changed from

==========
[modules] Split exports into regular and special, store regular ones in a
multimap.

BUG=v8:1569
==========

to

==========
[modules] Split exports into regular and special, store regular ones in a
multimap.

BUG=v8:1569
==========

[commit-bot: I haz the power, 2016-08-25 08:37:17]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-25 08:37:34]

Description was changed from

==========
[modules] Split exports into regular and special, store regular ones in a
multimap.

BUG=v8:1569
==========

to

==========
[modules] Split exports into regular and special, store regular ones in a
multimap.

BUG=v8:1569

Committed: https://crrev.com/6e67d042601bb6773c7a73dc3e290bdb50b4e68e
Cr-Commit-Position: refs/heads/master@{#38889}
==========

[commit-bot: I haz the power, 2016-08-25 08:37:35]

Patchset 4 (id:??) landed as
https://crrev.com/6e67d042601bb6773c7a73dc3e290bdb50b4e68e
Cr-Commit-Position: refs/heads/master@{#38889}