Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2272993004: Clarify devtools console log when a passive event listener is preventDefaulted. (Closed)

Created:
4 years, 4 months ago by dtapuska
Modified:
4 years, 3 months ago
Reviewers:
bokan
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clarify devtools console log when a passive event listener is preventDefaulted. Add a reference to the chromestatus entry regarding document level passive event listeners. BUG=627104 Committed: https://crrev.com/0e41c539d0f1d7cf0d4bcf425472ec6e7057d25a Cr-Commit-Position: refs/heads/master@{#414462}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add not reached #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -11 lines) Patch
M third_party/WebKit/Source/core/events/Event.h View 5 chunks +10 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/Event.cpp View 1 3 chunks +21 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/events/EventTarget.cpp View 3 chunks +11 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/TouchEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
dtapuska
4 years, 4 months ago (2016-08-24 20:16:06 UTC) #3
bokan
lgtm https://codereview.chromium.org/2272993004/diff/1/third_party/WebKit/Source/core/events/Event.cpp File third_party/WebKit/Source/core/events/Event.cpp (right): https://codereview.chromium.org/2272993004/diff/1/third_party/WebKit/Source/core/events/Event.cpp#newcode236 third_party/WebKit/Source/core/events/Event.cpp:236: break; perhaps this should be an ASSERT_NOT_REACHED?
4 years, 3 months ago (2016-08-25 13:19:44 UTC) #7
dtapuska
https://codereview.chromium.org/2272993004/diff/1/third_party/WebKit/Source/core/events/Event.cpp File third_party/WebKit/Source/core/events/Event.cpp (right): https://codereview.chromium.org/2272993004/diff/1/third_party/WebKit/Source/core/events/Event.cpp#newcode236 third_party/WebKit/Source/core/events/Event.cpp:236: break; On 2016/08/25 at 13:19:44, bokan wrote: > perhaps ...
4 years, 3 months ago (2016-08-25 14:02:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272993004/20001
4 years, 3 months ago (2016-08-25 14:03:23 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-25 17:17:29 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 17:19:56 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0e41c539d0f1d7cf0d4bcf425472ec6e7057d25a
Cr-Commit-Position: refs/heads/master@{#414462}

Powered by Google App Engine
This is Rietveld 408576698