| OLD | NEW | 
|    1 # Copyright 2016 The Chromium Authors. All rights reserved. |    1 # Copyright 2016 The Chromium Authors. All rights reserved. | 
|    2 # Use of this source code is governed by a BSD-style license that can be |    2 # Use of this source code is governed by a BSD-style license that can be | 
|    3 # found in the LICENSE file. |    3 # found in the LICENSE file. | 
|    4  |    4  | 
|    5 """Run all system health stories used by system health benchmarks. |    5 """Run all system health stories used by system health benchmarks. | 
|    6  |    6  | 
|    7 Only memory benchmarks are used when running these stories to make the total |    7 Only memory benchmarks are used when running these stories to make the total | 
|    8 cycle time manageable. Other system health benchmarks should be using the same |    8 cycle time manageable. Other system health benchmarks should be using the same | 
|    9 stories as memory ones, only with fewer actions (no memory dumping). |    9 stories as memory ones, only with fewer actions (no memory dumping). | 
|   10 """ |   10 """ | 
| (...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after  Loading... | 
|   42   # These tests are taking too long (more than 100s each). |   42   # These tests are taking too long (more than 100s each). | 
|   43   # TODO(nedn): reenable these test once we have more capacity to run them on |   43   # TODO(nedn): reenable these test once we have more capacity to run them on | 
|   44   # CQ. |   44   # CQ. | 
|   45   'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea
     lth.memory_mobile.browse:news:flipboard',  # pylint: disable=line-too-long |   45   'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea
     lth.memory_mobile.browse:news:flipboard',  # pylint: disable=line-too-long | 
|   46   'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea
     lth.memory_mobile.browse:media:imgur',  # pylint: disable=line-too-long |   46   'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea
     lth.memory_mobile.browse:media:imgur',  # pylint: disable=line-too-long | 
|   47   'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea
     lth.memory_mobile.browse:media:youtube',  # pylint: disable=line-too-long |   47   'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea
     lth.memory_mobile.browse:media:youtube',  # pylint: disable=line-too-long | 
|   48   'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea
     lth.memory_mobile.browse:media:facebook_photos',  # pylint: disable=line-too-lon
     g |   48   'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea
     lth.memory_mobile.browse:media:facebook_photos',  # pylint: disable=line-too-lon
     g | 
|   49   'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea
     lth.memory_mobile.browse:news:reddit',  # pylint: disable=line-too-long |   49   'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea
     lth.memory_mobile.browse:news:reddit',  # pylint: disable=line-too-long | 
|   50   'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea
     lth.memory_mobile.browse:social:facebook',  # pylint: disable=line-too-long |   50   'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea
     lth.memory_mobile.browse:social:facebook',  # pylint: disable=line-too-long | 
|   51   'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea
     lth.memory_mobile.load:news:cnn',  # pylint: disable=line-too-long |   51   'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea
     lth.memory_mobile.load:news:cnn',  # pylint: disable=line-too-long | 
 |   52  | 
 |   53   # Permenently disabled from smoke test for being long-running. | 
 |   54   'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea
     lth.memory_mobile.long_running:tools:gmail-foreground',  # pylint: disable=line-
     too-long | 
 |   55   'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea
     lth.memory_mobile.long_running:tools:gmail-background',  # pylint: disable=line-
     too-long | 
 |   56   'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea
     lth.memory_desktop.long_running:tools:gmail-foreground',  # pylint: disable=line
     -too-long | 
 |   57   'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea
     lth.memory_desktop.long_running:tools:gmail-background',  # pylint: disable=line
     -too-long | 
|   52 }) |   58 }) | 
|   53  |   59  | 
|   54  |   60  | 
|   55 def _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test): |   61 def _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test): | 
|   56  |   62  | 
|   57   # NOTE TO SHERIFFS: DO NOT DISABLE THIS TEST. |   63   # NOTE TO SHERIFFS: DO NOT DISABLE THIS TEST. | 
|   58   # |   64   # | 
|   59   # This smoke test dynamically tests all system health user stories. So |   65   # This smoke test dynamically tests all system health user stories. So | 
|   60   # disabling it for one failing or flaky benchmark would disable a much |   66   # disabling it for one failing or flaky benchmark would disable a much | 
|   61   # wider swath of coverage  than is usally intended. Instead, if a test is |   67   # wider swath of coverage  than is usally intended. Instead, if a test is | 
| (...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after  Loading... | 
|  137     # parsed during test time which happens after load_tests are called. |  143     # parsed during test time which happens after load_tests are called. | 
|  138     # Since none of our system health benchmarks creates stories based on |  144     # Since none of our system health benchmarks creates stories based on | 
|  139     # command line options, it should be ok to pass options=None to |  145     # command line options, it should be ok to pass options=None to | 
|  140     # CreateStorySet. |  146     # CreateStorySet. | 
|  141     for story_to_smoke_test in ( |  147     for story_to_smoke_test in ( | 
|  142         benchmark_class().CreateStorySet(options=None).stories): |  148         benchmark_class().CreateStorySet(options=None).stories): | 
|  143       suite.addTest( |  149       suite.addTest( | 
|  144           _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test)) |  150           _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test)) | 
|  145  |  151  | 
|  146   return suite |  152   return suite | 
| OLD | NEW |