Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1449)

Unified Diff: appengine/findit/handlers/test/config_test.py

Issue 2272953002: [Findit] Moving check flake parameters to config (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Fixing naming in html file Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/handlers/test/config_test.py
diff --git a/appengine/findit/handlers/test/config_test.py b/appengine/findit/handlers/test/config_test.py
index 2280eaa24f1b5fd7b6022804847c5533ee53b718..b6a6fbbb2cf9e7d8d360aa3a9203fdbfa3a52603 100644
--- a/appengine/findit/handlers/test/config_test.py
+++ b/appengine/findit/handlers/test/config_test.py
@@ -81,6 +81,13 @@ _MOCK_ACTION_SETTINGS = {
'cr_notification_latency_limit_minutes': 1000,
}
+_MOCK_CHECK_FLAKE_SETTINGS = {
+ 'lower_flake_threshold': 0.02,
+ 'upper_flake_threshold': 0.98,
+ 'max_flake_in_a_row': 4,
+ 'max_stable_in_a_row': 4
+}
+
_MOCK_VERSION_NUMBER = 12
@@ -97,6 +104,7 @@ class ConfigTest(testing.AppengineTestCase):
'swarming_settings': _MOCK_SWARMING_SETTINGS,
'download_build_data_settings': _MOCK_DOWNLOAD_BUILD_DATA_SETTINGS,
'action_settings': _MOCK_ACTION_SETTINGS,
+ 'check_flake_settings': _MOCK_CHECK_FLAKE_SETTINGS
}
self.mock_current_user(user_email='test@chromium.org', is_admin=True)
@@ -114,6 +122,7 @@ class ConfigTest(testing.AppengineTestCase):
'swarming_settings': _MOCK_SWARMING_SETTINGS,
'download_build_data_settings': _MOCK_DOWNLOAD_BUILD_DATA_SETTINGS,
'action_settings': _MOCK_ACTION_SETTINGS,
+ 'check_flake_settings': _MOCK_CHECK_FLAKE_SETTINGS,
'version': 1,
'latest_version': 1,
'updated_by': 'test',
@@ -132,6 +141,7 @@ class ConfigTest(testing.AppengineTestCase):
'swarming_settings': _MOCK_SWARMING_SETTINGS,
'download_build_data_settings': _MOCK_DOWNLOAD_BUILD_DATA_SETTINGS,
'action_settings': _MOCK_ACTION_SETTINGS,
+ 'check_flake_settings': _MOCK_CHECK_FLAKE_SETTINGS
}
wf_config.FinditConfig.Get().Update(users.GetCurrentUser(), True,
**config_data)
@@ -147,6 +157,7 @@ class ConfigTest(testing.AppengineTestCase):
'swarming_settings': _MOCK_SWARMING_SETTINGS,
'download_build_data_settings': _MOCK_DOWNLOAD_BUILD_DATA_SETTINGS,
'action_settings': _MOCK_ACTION_SETTINGS,
+ 'check_flake_settings': _MOCK_CHECK_FLAKE_SETTINGS,
'version': 1,
'latest_version': 1,
'updated_by': 'test',
@@ -659,6 +670,7 @@ class ConfigTest(testing.AppengineTestCase):
'swarming_settings': _MOCK_SWARMING_SETTINGS,
'download_build_data_settings': _MOCK_DOWNLOAD_BUILD_DATA_SETTINGS,
'action_settings': _MOCK_ACTION_SETTINGS,
+ 'check_flake_settings': _MOCK_CHECK_FLAKE_SETTINGS
})
}
@@ -687,6 +699,7 @@ class ConfigTest(testing.AppengineTestCase):
'swarming_settings': _MOCK_SWARMING_SETTINGS,
'download_build_data_settings': _MOCK_DOWNLOAD_BUILD_DATA_SETTINGS,
'action_settings': _MOCK_ACTION_SETTINGS,
+ 'check_flake_settings': _MOCK_CHECK_FLAKE_SETTINGS,
'version': 1,
'latest_version': 1,
'updated_by': 'test',

Powered by Google App Engine
This is Rietveld 408576698