Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2272933002:
Cleanup nits in PrintViewManager. (Closed)
DescriptionCleanup nits in PrintViewManager.
- Remove unused includes.
- Use auto and nullptr.
- Simplify code.
Committed: https://crrev.com/9ea5dcb49cb58db7e3157f04ff40a02efe9f3468
Cr-Commit-Position: refs/heads/master@{#414802}
Patch Set 1 #
Total comments: 3
Messages
Total messages: 22 (11 generated)
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Cleanup nits in PrintViewManager. ========== to ========== Cleanup nits in PrintViewManager. - Remove unused includes. - Use auto and nullptr. - Simplify code. ==========
thestig@chromium.org changed reviewers: + tommycli@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
ping
oops I will look at this now On Fri, Aug 26, 2016 at 9:36 AM, <thestig@chromium.org> wrote: > ping > > https://codereview.chromium.org/2272933002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
lgtm looks like no changes in behavior. nit below https://codereview.chromium.org/2272933002/diff/1/chrome/browser/printing/pri... File chrome/browser/printing/print_view_manager.cc (right): https://codereview.chromium.org/2272933002/diff/1/chrome/browser/printing/pri... chrome/browser/printing/print_view_manager.cc:160: if (base::ContainsKey(map, rph)) { nit: no need for comment anymore?
https://codereview.chromium.org/2272933002/diff/1/chrome/browser/printing/pri... File chrome/browser/printing/print_view_manager.cc (right): https://codereview.chromium.org/2272933002/diff/1/chrome/browser/printing/pri... chrome/browser/printing/print_view_manager.cc:160: if (base::ContainsKey(map, rph)) { On 2016/08/26 16:40:13, tommycli wrote: > nit: no need for comment anymore? Are you referring to the old line 167 comment? Slightly redundant with the comment right below.
thx thestig https://codereview.chromium.org/2272933002/diff/1/chrome/browser/printing/pri... File chrome/browser/printing/print_view_manager.cc (right): https://codereview.chromium.org/2272933002/diff/1/chrome/browser/printing/pri... chrome/browser/printing/print_view_manager.cc:160: if (base::ContainsKey(map, rph)) { On 2016/08/26 16:42:19, Lei Zhang wrote: > On 2016/08/26 16:40:13, tommycli wrote: > > nit: no need for comment anymore? > > Are you referring to the old line 167 comment? Slightly redundant with the > comment right below. yeah. okay cool
The CQ bit was checked by thestig@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by thestig@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Cleanup nits in PrintViewManager. - Remove unused includes. - Use auto and nullptr. - Simplify code. ========== to ========== Cleanup nits in PrintViewManager. - Remove unused includes. - Use auto and nullptr. - Simplify code. ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Cleanup nits in PrintViewManager. - Remove unused includes. - Use auto and nullptr. - Simplify code. ========== to ========== Cleanup nits in PrintViewManager. - Remove unused includes. - Use auto and nullptr. - Simplify code. Committed: https://crrev.com/9ea5dcb49cb58db7e3157f04ff40a02efe9f3468 Cr-Commit-Position: refs/heads/master@{#414802} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/9ea5dcb49cb58db7e3157f04ff40a02efe9f3468 Cr-Commit-Position: refs/heads/master@{#414802} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
