Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Issue 2272913002: Add UseCounter to count InvalidStateError by input.selectionStart, selectionEnd, and selectionDirec… (Closed)

Created:
4 years, 4 months ago by tkent
Modified:
4 years, 4 months ago
Reviewers:
Ilya Sherman, kojii
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UseCounter to count InvalidStateError by input.selectionStart, selectionEnd, and selectionDirection getters. We'd like to remove this InvalidStateError. BUG=622679 R=isherman@chromium.org, kojii@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/e6905fe7256d51d02a0cd778fd3c34611b88e413

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 3 chunks +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
tkent
kojii@, isherman@, would you review this please? very trivial
4 years, 4 months ago (2016-08-24 02:25:05 UTC) #2
Ilya Sherman
histograms.xml lgtm
4 years, 4 months ago (2016-08-24 03:08:37 UTC) #5
kojii
lgtm
4 years, 4 months ago (2016-08-24 03:20:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272913002/1
4 years, 4 months ago (2016-08-24 03:24:00 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e6905fe7256d51d02a0cd778fd3c34611b88e413 Cr-Commit-Position: refs/heads/master@{#413991}
4 years, 4 months ago (2016-08-24 06:05:30 UTC) #12
tkent
4 years, 4 months ago (2016-08-24 06:07:01 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e6905fe7256d51d02a0cd778fd3c34611b88e413 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698