Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2272883004: Fix the issue while clicking on offline page donwload notification (Closed)

Created:
4 years, 3 months ago by qinmin
Modified:
4 years, 3 months ago
Reviewers:
gone, fgorski
CC:
chromium-reviews, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the issue while clicking on offline page donwload notification When OfflinePageDownloadBridge is created, it will load all the offline page items. However, openItem() can get called before all page items are loaded. This causes the native side unable to find the downloaded item. As a result, nothing happens when user clicks offline page download success notification. This CL waits for all the page items to get loaded before calling openItem(). BUG=640467 Committed: https://crrev.com/7b88754c9ab1470d9732cb1f2e0a8deb65c590c9 Cr-Commit-Position: refs/heads/master@{#414317}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java View 2 chunks +17 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
qinmin
PTAL
4 years, 3 months ago (2016-08-25 00:15:51 UTC) #2
gone
lgtm
4 years, 3 months ago (2016-08-25 00:26:08 UTC) #3
fgorski
lgtm
4 years, 3 months ago (2016-08-25 01:29:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272883004/1
4 years, 3 months ago (2016-08-25 04:15:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 05:28:49 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 05:30:44 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b88754c9ab1470d9732cb1f2e0a8deb65c590c9
Cr-Commit-Position: refs/heads/master@{#414317}

Powered by Google App Engine
This is Rietveld 408576698