Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: extensions/browser/api/app_runtime/app_runtime_api.cc

Issue 2272813003: Add ARC++ specific fields to launch data for specific apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: chrome build fix. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/api/app_runtime/app_runtime_api.h ('k') | extensions/common/api/app_runtime.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/app_runtime/app_runtime_api.cc
diff --git a/extensions/browser/api/app_runtime/app_runtime_api.cc b/extensions/browser/api/app_runtime/app_runtime_api.cc
index f1d106520a7cf0fc140947f407f5bd4fd4bf3c80..c3f5df2d3c89dd4b2c2ea4abce28c81ec9ddc98e 100644
--- a/extensions/browser/api/app_runtime/app_runtime_api.cc
+++ b/extensions/browser/api/app_runtime/app_runtime_api.cc
@@ -8,6 +8,7 @@
#include <utility>
+#include "base/memory/ptr_util.h"
#include "base/metrics/histogram.h"
#include "base/time/time.h"
#include "base/values.h"
@@ -138,18 +139,16 @@ void AppRuntimeEventRouter::DispatchOnLaunchedEvent(
BrowserContext* context,
const Extension* extension,
extensions::AppLaunchSource source,
- std::unique_ptr<app_runtime::ActionData> action_data) {
- app_runtime::LaunchData launch_data;
-
+ std::unique_ptr<app_runtime::LaunchData> launch_data) {
+ if (!launch_data)
+ launch_data = base::MakeUnique<app_runtime::LaunchData>();
app_runtime::LaunchSource source_enum = GetLaunchSourceEnum(source);
if (extensions::FeatureSwitch::trace_app_source()->IsEnabled()) {
- launch_data.source = source_enum;
+ launch_data->source = source_enum;
}
- launch_data.action_data = std::move(action_data);
-
DispatchOnLaunchedEventImpl(extension->id(), source_enum,
- launch_data.ToValue(), context);
+ launch_data->ToValue(), context);
}
// static
« no previous file with comments | « extensions/browser/api/app_runtime/app_runtime_api.h ('k') | extensions/common/api/app_runtime.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698