Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3821)

Unified Diff: chrome/browser/ui/views/website_settings/chosen_object_row.h

Issue 2272793007: Material Page Info (Views, 1/3): Rename {ChosenObject, PermissionSelector}View classes to {...}Row. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/website_settings/chosen_object_row.h
diff --git a/chrome/browser/ui/views/website_settings/chosen_object_view.h b/chrome/browser/ui/views/website_settings/chosen_object_row.h
similarity index 60%
rename from chrome/browser/ui/views/website_settings/chosen_object_view.h
rename to chrome/browser/ui/views/website_settings/chosen_object_row.h
index fafd59e44dd971882912fbcdb09340300252b938..728aff81e3a2f4e76b73e074ff6148ca549620ab 100644
--- a/chrome/browser/ui/views/website_settings/chosen_object_view.h
+++ b/chrome/browser/ui/views/website_settings/chosen_object_row.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_UI_VIEWS_WEBSITE_SETTINGS_CHOSEN_OBJECT_VIEW_H_
-#define CHROME_BROWSER_UI_VIEWS_WEBSITE_SETTINGS_CHOSEN_OBJECT_VIEW_H_
+#ifndef CHROME_BROWSER_UI_VIEWS_WEBSITE_SETTINGS_CHOSEN_OBJECT_ROW_H_
+#define CHROME_BROWSER_UI_VIEWS_WEBSITE_SETTINGS_CHOSEN_OBJECT_ROW_H_
#include "base/macros.h"
#include "chrome/browser/ui/website_settings/website_settings_ui.h"
@@ -18,17 +18,20 @@ class ImageButton;
class ImageView;
}
-class ChosenObjectViewObserver;
+class ChosenObjectRowObserver;
-class ChosenObjectView : public views::View, public views::ButtonListener {
+// A ChosenObjectRow is a row in the Page Info bubble that shows an individual
+// object (e.g. a Bluetooth device, a USB device) that the current site has
+// access to.
+class ChosenObjectRow : public views::View, public views::ButtonListener {
public:
- explicit ChosenObjectView(
+ explicit ChosenObjectRow(
std::unique_ptr<WebsiteSettingsUI::ChosenObjectInfo> info);
- void AddObserver(ChosenObjectViewObserver* observer);
+ void AddObserver(ChosenObjectRowObserver* observer);
private:
- ~ChosenObjectView() override;
+ ~ChosenObjectRow() override;
// views::ButtonListener implementation.
void ButtonPressed(views::Button* sender, const ui::Event& event) override;
@@ -36,10 +39,10 @@ class ChosenObjectView : public views::View, public views::ButtonListener {
views::ImageView* icon_; // Owned by the views hierarchy.
views::ImageButton* delete_button_; // Owned by the views hierarchy.
- base::ObserverList<ChosenObjectViewObserver> observer_list_;
+ base::ObserverList<ChosenObjectRowObserver> observer_list_;
std::unique_ptr<WebsiteSettingsUI::ChosenObjectInfo> info_;
- DISALLOW_COPY_AND_ASSIGN(ChosenObjectView);
+ DISALLOW_COPY_AND_ASSIGN(ChosenObjectRow);
};
-#endif // CHROME_BROWSER_UI_VIEWS_WEBSITE_SETTINGS_CHOSEN_OBJECT_VIEW_H_
+#endif // CHROME_BROWSER_UI_VIEWS_WEBSITE_SETTINGS_CHOSEN_OBJECT_ROW_H_

Powered by Google App Engine
This is Rietveld 408576698