chrome/browser/ui/views/website_settings/website_settings_popup_view.h - Issue 2272793007: Material Page Info (Views, 1/3): Rename {ChosenObject, PermissionSelector}View classes to {...}Row.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/website_settings/website_settings_popup_view.h

Issue 2272793007: Material Page Info (Views, 1/3): Rename {ChosenObject, PermissionSelector}View classes to {...}Row. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix rebase-induced formatting throughout permission_selector_row. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/website_settings/permission_selector_view_observer.h ('k') | chrome/browser/ui/views/website_settings/website_settings_popup_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/website_settings/website_settings_popup_view.h

diff --git a/chrome/browser/ui/views/website_settings/website_settings_popup_view.h b/chrome/browser/ui/views/website_settings/website_settings_popup_view.h

index ae4bb2d085b4e50e59d70e882ca6b34342667af6..c0f1c85dbac75a286020f66d9f290a325036693f 100644

--- a/chrome/browser/ui/views/website_settings/website_settings_popup_view.h

+++ b/chrome/browser/ui/views/website_settings/website_settings_popup_view.h

@@ -11,8 +11,8 @@

#include "base/macros.h"

#include "base/memory/weak_ptr.h"

#include "base/strings/string16.h"

-#include "chrome/browser/ui/views/website_settings/chosen_object_view_observer.h"

-#include "chrome/browser/ui/views/website_settings/permission_selector_view_observer.h"

+#include "chrome/browser/ui/views/website_settings/chosen_object_row_observer.h"

+#include "chrome/browser/ui/views/website_settings/permission_selector_row_observer.h"

#include "chrome/browser/ui/website_settings/website_settings_ui.h"

#include "components/security_state/security_state_model.h"

#include "content/public/browser/web_contents_observer.h"

@@ -51,8 +51,8 @@ enum : int {

// The views implementation of the website settings UI.

class WebsiteSettingsPopupView : public content::WebContentsObserver,

- public PermissionSelectorViewObserver,

- public ChosenObjectViewObserver,

+ public PermissionSelectorRowObserver,

+ public ChosenObjectRowObserver,

public views::BubbleDialogDelegateView,

public views::ButtonListener,

public views::LinkListener,

@@ -87,11 +87,11 @@ class WebsiteSettingsPopupView : public content::WebContentsObserver,

void RenderFrameDeleted(content::RenderFrameHost* render_frame_host) override;

void WebContentsDestroyed() override;

- // PermissionSelectorViewObserver implementation.

+ // PermissionSelectorRowObserver implementation.

void OnPermissionChanged(

const WebsiteSettingsUI::PermissionInfo& permission) override;

- // ChosenObjectViewObserver implementation.

+ // ChosenObjectRowObserver implementation.

void OnChosenObjectDeleted(

const WebsiteSettingsUI::ChosenObjectInfo& info) override;