Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 2272793004: Update some switchable call stub names and comments. (Closed)

Created:
4 years, 4 months ago by rmacnak
Modified:
4 years, 4 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : megamorphic #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -45 lines) Patch
M runtime/vm/code_generator.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/precompiler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/stub_code.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 1 2 3 chunks +6 lines, -5 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/thread.h View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 4 months ago (2016-08-23 23:17:15 UTC) #2
Florian Schneider
lgtm
4 years, 4 months ago (2016-08-23 23:25:57 UTC) #3
rmacnak
4 years, 4 months ago (2016-08-24 00:28:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
e40b4fd2c56a9c52e340a99e2d682e2ef6bd6aea (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698