Make WebViewImpl::textInputInfo update layout before working on ranges.

third_party/WebKit/Source/web/tests/WebViewTest.cpp

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 713 matching lines @@
 {
     testTextInputType(WebTextInputTypeText, "input_field_default.html");
     testTextInputType(WebTextInputTypePassword, "input_field_password.html");
     testTextInputType(WebTextInputTypeEmail, "input_field_email.html");
     testTextInputType(WebTextInputTypeSearch, "input_field_search.html");
     testTextInputType(WebTextInputTypeNumber, "input_field_number.html");
     testTextInputType(WebTextInputTypeTelephone, "input_field_tel.html");
     testTextInputType(WebTextInputTypeURL, "input_field_url.html");
 }
 
+TEST_F(WebViewTest, TextInputInfoUpdateStyleAndLayout)
+{
+    FrameTestHelpers::TestWebViewClient client;
+    FrameTestHelpers::WebViewHelper m_webViewHelper;
+    WebViewImpl* webViewImpl = m_webViewHelper.initialize(true, 0, &client);

[esprehn, 2016/08/26 05:23:03]

I suspect this would be a pretty simple SimTest without all of this setup

+
+    WebURL baseURL = URLTestHelpers::toKURL("http://example.com/");
+    // Here, we need to construct a document that has a special property:
+    // Adding id="foo" to the <path> element will trigger creation of an SVG instance tree
+    // for the use <use> element.
+    // This is significant, because SVG instance trees are actually created lazily
+    // during Document::updateStyleAndLayout code, thus incrementing the DOM tree version
+    // and freaking out the EphemeralRange (invalidating it).
+    FrameTestHelpers::loadHTMLString(webViewImpl->mainFrame(),
+        "<svg height=\"100%\" version=\"1.1\" viewBox=\"0 0 14 14\" width=\"100%\">"

[esprehn, 2016/08/26 05:23:03]

if you use single quotes you can avoid the escapes all over

+        "<use xmlns:xlink=\"http://www.w3.org/1999/xlink\" xlink:href=\"#foo\"></use>"
+        "<path d=\"M 100 100 L 300 100 L 200 300 z\" fill=\"#000\"></path>"
+        "</svg>"
+        "<input>", baseURL);
+    webViewImpl->setInitialFocus(false);
+
+    // Add id="foo" to <path>, thus triggering the condition described above.
+    LocalFrame* mainFrameLocal = toLocalFrame(webViewImpl->page()->mainFrame());
+    mainFrameLocal->document()->body()->querySelector("path", IGNORE_EXCEPTION)->setIdAttribute("foo");

[esprehn, 2016/08/26 05:23:02]

don't ignore the exception, ASSERT_NO_EXCEPTION, which is the default, is what
you want.


Also:

webViewImpl->mainFrameImpl()->frame()->document() does what you want here, no
need to touch page()

+
+    // This should not DCHECK.
+    EXPECT_EQ(WebTextInputTypeText, webViewImpl->textInputInfo().type);
+}
+
 void WebViewTest::testInputMode(const WebString& expectedInputMode, const std::string& htmlFile)
 {
     URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(m_baseURL.c_str()), WebString::fromUTF8(htmlFile.c_str()));
     WebView* webView = m_webViewHelper.initializeAndLoad(m_baseURL + htmlFile);
     webView->setInitialFocus(false);
     EXPECT_EQ(expectedInputMode, webView->textInputInfo().inputMode);
 }
 
 TEST_F(WebViewTest, InputMode)
 {
@@ skipping 2536 matching lines @@
             EXPECT_TRUE(webView->page()->defersLoading());
         }
 
         EXPECT_TRUE(webView->page()->defersLoading());
     }
 
     EXPECT_FALSE(webView->page()->defersLoading());
 }
 
 } // namespace blink