Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1080)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_private.mm

Issue 2272783002: [Mac] Fix for fullscreen toolbar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller_private.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller_private.mm b/chrome/browser/ui/cocoa/browser_window_controller_private.mm
index 6bbb6d210f397861d7d4aa664cb132e646486e32..7e6e3eeb9ed99521fc3333c559544e57fdf36d60 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller_private.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller_private.mm
@@ -454,14 +454,9 @@ willPositionSheet:(NSWindow*)sheet
}
- (void)configureFullscreenToolbarController {
- BOOL fullscreenForTab = [self isFullscreenForTabContentOrExtension];
- BOOL kioskMode =
- base::CommandLine::ForCurrentProcess()->HasSwitch(switches::kKioskMode);
- BOOL showDropdown =
- !fullscreenForTab && !kioskMode && ([self floatingBarHasFocus]);
-
+ NSView* contentView = [[self window] contentView];
[fullscreenToolbarController_
- setupFullscreenToolbarWithDropdown:showDropdown];
+ setupFullscreenToolbarForContentView:contentView];
}
- (void)adjustUIForExitingFullscreenAndStopOmniboxSliding {
@@ -474,6 +469,10 @@ willPositionSheet:(NSWindow*)sheet
}
- (void)adjustUIForSlidingFullscreenStyle:(fullscreen_mac::SlidingStyle)style {
+ // The UI should only be adjusted in fullscreen mode.
+ if (![self isInAnyFullscreenMode])
+ return;
+
if (!fullscreenToolbarController_) {
fullscreenToolbarController_.reset(
[self newFullscreenToolbarControllerWithStyle:style]);
@@ -1009,8 +1008,11 @@ willPositionSheet:(NSWindow*)sheet
[self layoutTabContentArea:output.contentAreaFrame];
- if (!NSIsEmptyRect(output.fullscreenBackingBarFrame))
+ if (!NSIsEmptyRect(output.fullscreenBackingBarFrame)) {
[floatingBarBackingView_ setFrame:output.fullscreenBackingBarFrame];
+ [fullscreenToolbarController_
+ setTrackingAreaFromOverlayFrame:output.fullscreenBackingBarFrame];
+ }
[findBarCocoaController_
positionFindBarViewAtMaxY:output.findBarMaxY

Powered by Google App Engine
This is Rietveld 408576698