Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2272753002: ui/views: Pass InitParams::accept_events to NativeWidgetMus::content_ (Closed)

Created:
4 years, 4 months ago by Peng
Modified:
4 years, 3 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui/views: Pass InitParams::accept_events to NativeWidgetMus::content_ BUG=639861 Committed: https://crrev.com/d62216cfe1b73e2fa7c5384b3d8fb1dc03f794bb Cr-Commit-Position: refs/heads/master@{#414565}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/views/mus/native_widget_mus.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
Peng
Hi Sadrul, PTAL. Thanks
4 years, 4 months ago (2016-08-23 17:45:55 UTC) #2
sadrul
It's not clear what the underlying problem is. I have left a comment in the ...
4 years, 4 months ago (2016-08-24 17:34:26 UTC) #7
Peng
On 2016/08/24 17:34:26, sadrul wrote: > It's not clear what the underlying problem is. I ...
4 years, 4 months ago (2016-08-24 17:40:27 UTC) #8
Peng
On 2016/08/24 17:40:27, Peng wrote: > On 2016/08/24 17:34:26, sadrul wrote: > > It's not ...
4 years, 3 months ago (2016-08-25 15:33:59 UTC) #9
sadrul
lgtm. Can you add a test?
4 years, 3 months ago (2016-08-25 19:44:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272753002/1
4 years, 3 months ago (2016-08-25 20:03:24 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/281377) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
4 years, 3 months ago (2016-08-25 21:06:48 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272753002/1
4 years, 3 months ago (2016-08-25 21:12:52 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 22:44:15 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 22:46:56 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d62216cfe1b73e2fa7c5384b3d8fb1dc03f794bb
Cr-Commit-Position: refs/heads/master@{#414565}

Powered by Google App Engine
This is Rietveld 408576698