|
|
Chromium Code Reviews
Descriptionui/views: Pass InitParams::accept_events to NativeWidgetMus::content_
BUG=639861
Committed: https://crrev.com/d62216cfe1b73e2fa7c5384b3d8fb1dc03f794bb
Cr-Commit-Position: refs/heads/master@{#414565}
Patch Set 1 #
Messages
Total messages: 19 (9 generated)
penghuang@chromium.org changed reviewers: + sadrul@chromium.org
Hi Sadrul, PTAL. Thanks
The CQ bit was checked by penghuang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
It's not clear what the underlying problem is. I have left a comment in the bug.
On 2016/08/24 17:34:26, sadrul wrote: > It's not clear what the underlying problem is. I have left a comment in the bug. I can investigate it more later. But do you think if this change is necessary. I saw set_ignore_events is set in other nativrwidget too.
On 2016/08/24 17:40:27, Peng wrote: > On 2016/08/24 17:34:26, sadrul wrote: > > It's not clear what the underlying problem is. I have left a comment in the > bug. > > I can investigate it more later. > > But do you think if this change is necessary. I saw set_ignore_events is set in > other nativrwidget too. I found the events are not come from mus. They are synthesized by aura and sent to new created windows. So we need set the ignore_events() for content_; https://cs.chromium.org/chromium/src/ui/aura/window_event_dispatcher.cc?sq=pa...
lgtm. Can you add a test?
The CQ bit was checked by penghuang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by penghuang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== ui/views: Pass InitParams::accept_events to NativeWidgetMus::content_ BUG=639861 ========== to ========== ui/views: Pass InitParams::accept_events to NativeWidgetMus::content_ BUG=639861 Committed: https://crrev.com/d62216cfe1b73e2fa7c5384b3d8fb1dc03f794bb Cr-Commit-Position: refs/heads/master@{#414565} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/d62216cfe1b73e2fa7c5384b3d8fb1dc03f794bb Cr-Commit-Position: refs/heads/master@{#414565} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
