Do not initialize gestureconfiguration in renderer process

Do not initialize gestureconfiguration in renderer process

When multiprocess is enabled for webview, do not initialize
gesture configuration in renderer process as this eventually
leads to accessing Window Manager Service.

BUG=640379
Bug: b/31045266
Committed: https://crrev.com/2fc863f2c7fc232b37c9ced79ca6493bba498ed9
Cr-Commit-Position: refs/heads/master@{#414445}

[sgurun-gerrit only, 2016-08-25 01:52:43]

Description was changed from

==========
Do not initialize gestureconfiguration in renderer process

When multiprocess is enabled for webview, do not initialize
gesture configuration in renderer process as this eventually
leads to accessing Window Manager Service.

Bug: b/31045266
==========

to

==========
Do not initialize gestureconfiguration in renderer process

When multiprocess is enabled for webview, do not initialize
gesture configuration in renderer process as this eventually
leads to accessing Window Manager Service.

Bug: b/31045266
==========

[sgurun-gerrit only, 2016-08-25 01:52:44]

sgurun@chromium.org changed reviewers:
+ boliu@chromium.org

[sgurun-gerrit only, 2016-08-25 01:53:06]

On 2016/08/25 01:52:44, sgurun wrote:
> mailto:sgurun@chromium.org changed reviewers:
> + mailto:boliu@chromium.org

ptal

[boliu, 2016-08-25 02:45:52]

lgtm % first comment

probably should write a big note that that class runs once per process

https://codereview.chromium.org/2272703008/diff/1/android_webview/lib/main/aw...
File android_webview/lib/main/aw_main_delegate.cc (right):

https://codereview.chromium.org/2272703008/diff/1/android_webview/lib/main/aw...
android_webview/lib/main/aw_main_delegate.cc:70:
*base::CommandLine::ForCurrentProcess();
don't create another instance, re-use cl* pointer from below

actually, there's a browser process section near the end of this method already,
just move stuff to there instead

https://codereview.chromium.org/2272703008/diff/1/android_webview/lib/main/aw...
android_webview/lib/main/aw_main_delegate.cc:73: if (process_type !=
switches::kRendererProcess) {
you can also exclude RegisterMediaUrlInterceptor and CalculateTileMemoryPolicy
above

(doing this in separate CL is fine)

[sgurun-gerrit only, 2016-08-25 15:04:48]

https://codereview.chromium.org/2272703008/diff/1/android_webview/lib/main/aw...
File android_webview/lib/main/aw_main_delegate.cc (right):

https://codereview.chromium.org/2272703008/diff/1/android_webview/lib/main/aw...
android_webview/lib/main/aw_main_delegate.cc:70:
*base::CommandLine::ForCurrentProcess();
On 2016/08/25 02:45:52, boliu wrote:
> don't create another instance, re-use cl* pointer from below
> 
> actually, there's a browser process section near the end of this method
already,
> just move stuff to there instead

Done.

https://codereview.chromium.org/2272703008/diff/1/android_webview/lib/main/aw...
android_webview/lib/main/aw_main_delegate.cc:73: if (process_type !=
switches::kRendererProcess) {
On 2016/08/25 02:45:52, boliu wrote:
> you can also exclude RegisterMediaUrlInterceptor and CalculateTileMemoryPolicy
> above
> 
> (doing this in separate CL is fine)

Done.

[sgurun-gerrit only, 2016-08-25 15:04:54]

The CQ bit was checked by sgurun@chromium.org

[sgurun-gerrit only, 2016-08-25 15:04:55]

The patchset sent to the CQ was uploaded after l-g-t-m from boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/2272703008/#ps20001
(title: "Do not initialize gestureconfiguration in renderer process")

[sgurun-gerrit only, 2016-08-25 15:05:11]

The CQ bit was unchecked by sgurun@chromium.org

[commit-bot: I haz the power, 2016-08-25 15:05:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sgurun-gerrit only, 2016-08-25 15:05:42]

Description was changed from

==========
Do not initialize gestureconfiguration in renderer process

When multiprocess is enabled for webview, do not initialize
gesture configuration in renderer process as this eventually
leads to accessing Window Manager Service.

Bug: b/31045266
==========

to

==========
Do not initialize gestureconfiguration in renderer process

When multiprocess is enabled for webview, do not initialize
gesture configuration in renderer process as this eventually
leads to accessing Window Manager Service.

BUG=640379

Bug: b/31045266
==========

[sgurun-gerrit only, 2016-08-25 15:05:53]

The CQ bit was checked by sgurun@chromium.org

[commit-bot: I haz the power, 2016-08-25 15:06:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 15:47:56]

Description was changed from

==========
Do not initialize gestureconfiguration in renderer process

When multiprocess is enabled for webview, do not initialize
gesture configuration in renderer process as this eventually
leads to accessing Window Manager Service.

BUG=640379

Bug: b/31045266
==========

to

==========
Do not initialize gestureconfiguration in renderer process

When multiprocess is enabled for webview, do not initialize
gesture configuration in renderer process as this eventually
leads to accessing Window Manager Service.

BUG=640379

Bug: b/31045266
==========

[commit-bot: I haz the power, 2016-08-25 15:47:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-25 15:49:38]

Description was changed from

==========
Do not initialize gestureconfiguration in renderer process

When multiprocess is enabled for webview, do not initialize
gesture configuration in renderer process as this eventually
leads to accessing Window Manager Service.

BUG=640379

Bug: b/31045266
==========

to

==========
Do not initialize gestureconfiguration in renderer process

When multiprocess is enabled for webview, do not initialize
gesture configuration in renderer process as this eventually
leads to accessing Window Manager Service.

BUG=640379

Bug: b/31045266
Committed: https://crrev.com/2fc863f2c7fc232b37c9ced79ca6493bba498ed9
Cr-Commit-Position: refs/heads/master@{#414445}
==========

[commit-bot: I haz the power, 2016-08-25 15:49:39]

Patchset 2 (id:??) landed as
https://crrev.com/2fc863f2c7fc232b37c9ced79ca6493bba498ed9
Cr-Commit-Position: refs/heads/master@{#414445}