Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 2272703004: Add Ganesh support for circular roundrects with strokes > 2*radii. (Closed)

Created:
4 years, 4 months ago by jvanverth1
Modified:
4 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add Ganesh support for circular roundrects with strokes > 2*radii. Overstroked rrects are supported by adding additional geometry to the center of the nine patch, and setting constant offset vectors to fake out the distance calculation. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2272703004 Committed: https://skia.googlesource.com/skia/+/c3d0e422761702c52a974411eaf0b06d223fe98e

Patch Set 1 #

Patch Set 2 : Remove other changes #

Patch Set 3 : Some cleanup #

Total comments: 2

Patch Set 4 : Degenerate to fill for superwide strokes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -32 lines) Patch
M src/gpu/GrOvalRenderer.cpp View 1 2 3 14 chunks +160 lines, -32 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
jvanverth1
4 years, 3 months ago (2016-08-25 12:39:29 UTC) #3
robertphillips
lgtm https://codereview.chromium.org/2272703004/diff/40001/src/gpu/GrOvalRenderer.cpp File src/gpu/GrOvalRenderer.cpp (right): https://codereview.chromium.org/2272703004/diff/40001/src/gpu/GrOvalRenderer.cpp#newcode1457 src/gpu/GrOvalRenderer.cpp:1457: // TODO: if radius is really large this ...
4 years, 3 months ago (2016-08-25 12:55:42 UTC) #4
jvanverth1
https://codereview.chromium.org/2272703004/diff/40001/src/gpu/GrOvalRenderer.cpp File src/gpu/GrOvalRenderer.cpp (right): https://codereview.chromium.org/2272703004/diff/40001/src/gpu/GrOvalRenderer.cpp#newcode1457 src/gpu/GrOvalRenderer.cpp:1457: // TODO: if radius is really large this might ...
4 years, 3 months ago (2016-08-25 14:02:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272703004/60001
4 years, 3 months ago (2016-08-25 15:07:01 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 15:12:39 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/c3d0e422761702c52a974411eaf0b06d223fe98e

Powered by Google App Engine
This is Rietveld 408576698