Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2633)

Unified Diff: base/trace_event/trace_event.h

Issue 2272703002: Move AddTraceEvent out-of-line (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@before-sharing
Patch Set: Add missing BASE_EXPORT Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/BUILD.gn ('k') | base/trace_event/trace_event.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/trace_event.h
diff --git a/base/trace_event/trace_event.h b/base/trace_event/trace_event.h
index 53395dc670c76adf51108c5ea9c6f44abc2443fe..e854ca7c2f8cc857898ff554e13177c817852217 100644
--- a/base/trace_event/trace_event.h
+++ b/base/trace_event/trace_event.h
@@ -790,20 +790,14 @@ AddTraceEventWithThreadIdAndTimestamp(
timestamp, kZeroNumArgs, NULL, NULL, NULL, NULL, flags);
}
-static inline base::trace_event::TraceEventHandle AddTraceEvent(
+BASE_EXPORT base::trace_event::TraceEventHandle AddTraceEvent(
char phase,
const unsigned char* category_group_enabled,
const char* name,
const char* scope,
unsigned long long id,
unsigned int flags,
- unsigned long long bind_id) {
- const int thread_id = static_cast<int>(base::PlatformThread::CurrentId());
- const base::TimeTicks now = base::TimeTicks::Now();
- return AddTraceEventWithThreadIdAndTimestamp(
- phase, category_group_enabled, name, scope, id, thread_id, now, flags,
- bind_id);
-}
+ unsigned long long bind_id);
template<class ARG1_TYPE>
static inline base::trace_event::TraceEventHandle
« no previous file with comments | « base/BUILD.gn ('k') | base/trace_event/trace_event.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698