Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Unified Diff: third_party/WebKit/Source/modules/webaudio/StereoPannerNode.cpp

Issue 2272683003: Remove redundant definition of Spatializer abstract class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Detach StereoPanner from Panner base class (plus rebasing) Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/StereoPannerNode.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/StereoPannerNode.cpp b/third_party/WebKit/Source/modules/webaudio/StereoPannerNode.cpp
index b4edd857d1efbbb4c671d5be17d46198f1c38889..d3ae4f6f1f54fee2a6177b8e8aee12afaba0d82d 100644
--- a/third_party/WebKit/Source/modules/webaudio/StereoPannerNode.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/StereoPannerNode.cpp
@@ -63,10 +63,12 @@ void StereoPannerHandler::process(size_t framesToProcess)
if (framesToProcess <= m_sampleAccuratePanValues.size()) {
float* panValues = m_sampleAccuratePanValues.data();
m_pan->calculateSampleAccurateValues(panValues, framesToProcess);
- m_stereoPanner->panWithSampleAccurateValues(inputBus, outputBus, panValues, framesToProcess);
+ m_stereoPanner->panWithSampleAccurateValues(
Raymond Toy 2016/08/24 18:30:29 It looks like nothing changed here other than inde
hongchan 2016/08/24 21:52:33 Done.
+ inputBus, outputBus, panValues, framesToProcess);
}
} else {
- m_stereoPanner->panToTargetValue(inputBus, outputBus, m_pan->value(), framesToProcess);
+ m_stereoPanner->panToTargetValue(
+ inputBus, outputBus, m_pan->value(), framesToProcess);
Raymond Toy 2016/08/24 18:30:29 Please revert this indentation change.
hongchan 2016/08/24 21:52:33 Done.
}
}
@@ -75,7 +77,7 @@ void StereoPannerHandler::initialize()
if (isInitialized())
return;
- m_stereoPanner = Spatializer::create(Spatializer::PanningModelEqualPower, sampleRate());
+ m_stereoPanner = StereoPanner::create(sampleRate());
AudioHandler::initialize();
}

Powered by Google App Engine
This is Rietveld 408576698